From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4856FC3F68F for ; Tue, 17 Dec 2019 07:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F2F12082E for ; Tue, 17 Dec 2019 07:10:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="hDoyEcVB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfLQHKi (ORCPT ); Tue, 17 Dec 2019 02:10:38 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:57129 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbfLQHKi (ORCPT ); Tue, 17 Dec 2019 02:10:38 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576566637; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=d2doW9x45on2agTH9ruVafj9CaYtMfz8Ep8KJlG7+0w=; b=hDoyEcVBGVdPzBfCWa0MUY/B5QLq+7ClRkbbLYF9nnf3iXiryY5ATG87E7LafzEvuT+30pMP rWmvunBlWIsCczyFL9EBjArjbelVnsV3h7KYenbtr9s9rJKXYn2qJibqGwxkfRillF+b+xVC IrkVQr0KkUCxEfsutgSIRx2Z3Fk= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJlNmU5NiIsICJsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df87f68.7f6224590c38-smtp-out-n03; Tue, 17 Dec 2019 07:10:32 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7DAFDC447B0; Tue, 17 Dec 2019 07:10:30 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6E922C43383; Tue, 17 Dec 2019 07:10:29 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Dec 2019 15:10:29 +0800 From: cang@codeaurora.org To: Vinod Koul Cc: Jeffrey Hugo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, Rajendra Nayak , linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller In-Reply-To: <20191217041342.GM2536@vkoul-mobl> References: <1573798172-20534-1-git-send-email-cang@codeaurora.org> <1573798172-20534-3-git-send-email-cang@codeaurora.org> <20191216190415.GL2536@vkoul-mobl> <091562cbe7d88ca1c30638bc10197074@codeaurora.org> <20191217041342.GM2536@vkoul-mobl> Message-ID: <763d7b30593b31646f3c198c2be99671@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2019-12-17 12:13, Vinod Koul wrote: > Hi Can, > > On 17-12-19, 08:37, cang@codeaurora.org wrote: >> On 2019-12-17 03:12, Jeffrey Hugo wrote: >> > On Mon, Dec 16, 2019 at 12:05 PM Vinod Koul wrote: >> > > >> > > Hi Can, >> > > >> > > On 14-11-19, 22:09, Can Guo wrote: >> > > > Add reset control for host controller so that host controller can be reset >> > > > as required in its power up sequence. >> > > >> > > I am seeing a regression on UFS on SM8150-mtp with this patch. I think >> > > Jeff is seeing same one lenove laptop on 8998. >> > >> > Confirmed. >> > >> > > >> > > 845 does not seem to have this issue and only thing I can see is >> > > that on >> > > sm8150 and 8998 we define reset as: >> > > >> > > resets = <&gcc GCC_UFS_BCR>; >> > > reset-names = "rst"; >> > > >> >> Hi Jeffrey and Vinod, >> >> Thanks for reporting this. May I know what kind of regression do you >> see on >> 8150 and 8998? >> BTW, do you have reset control for UFS PHY in your DT? >> See 71278b058a9f8752e51030e363b7a7306938f64e. >> >> FYI, we use reset control on all of our platforms and it is >> a must during our power up sequence. > > Yes we do have this and additionally both the DTS describe a 'rst' > reset > and this patch tries to use this. > > Can you please tell me which platform this was tested on how the reset > was described in DT > > Thanks Hi Vinod, If you are using the 8998's DT present on upstream, you may also need to enable device reset on your platform. (We usually do a device reset before call ufshcd_hba_enable()) Given that 845 works fine, it may be the difference you have with 845. 845 has device reset support ready in upstream code, you can check sdm845-mtp.dts. It is same for 8150, which is a lack of device reset support in upstream code base. To enable UFS device reset, please see 1. https://lore.kernel.org/linux-arm-msm/20190828191756.24312-4-bjorn.andersson@linaro.org/ 2. 53a5372ce326116f3e3d3f1d701113b2542509f4 FYI, I tested the patch on 8250 and its family platforms. In my build, I ported change in #2 to my code base (in your case, make change to drivers/pinctrl/qcom/pinctrl-msm8998.c) and enable the GPIO in DT like sdm845-mtp.dts reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>; Thanks