From: Yu Kuai <yukuai1@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>, Ming Lei <ming.lei@redhat.com>,
Jan Kara <jack@suse.cz>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC] scsi: core: remove unsed 'restarts' from scsi_device
Date: Tue, 29 Nov 2022 10:15:04 +0800 [thread overview]
Message-ID: <8280fa32-4a96-be98-06ac-1890f95f026f@huaweicloud.com> (raw)
In-Reply-To: <1caa7d49-0322-3eb9-7e99-6be96f77c80a@huaweicloud.com>
Hi,
> Hi,
>
> 在 2022/11/28 12:12, Ming Lei 写道:
>>
>> BTW, why do you drive nvme via megaraid instead nvme driver?
>>
>>> And by the way, after Jan's patch "blk-mq: Improve performance of non-mq
>>> IO schedulers with multiple HW queues", scsi_run_queue_async() can only
>>> garantee to run hw queue for the current cpu, not all the hw queues.
>>
>> That isn't true, each hctx is still run in case of none & kyber
>> scheduler.
And I really suspect that why Jan's patch can improve performance is
because it avoid many run queues from scsi_run_queue_async().
>
> Yes, but current default hctx shared elevator is deadline.
>>
>> thanks,
>> Ming
>>
>> .
>>
>
> .
>
prev parent reply other threads:[~2022-11-29 2:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 11:30 [PATCH RFC] scsi: core: remove unsed 'restarts' from scsi_device Yu Kuai
2022-11-19 1:11 ` Bart Van Assche
2022-11-19 5:57 ` Yu Kuai
2022-11-26 8:54 ` Yu Kuai
2022-11-27 9:45 ` Ming Lei
2022-11-28 2:26 ` Jason Yan
2022-11-28 3:27 ` Ming Lei
2022-11-28 3:35 ` Yu Kuai
2022-11-28 3:38 ` Yu Kuai
2022-11-28 4:12 ` Ming Lei
2022-11-28 6:08 ` Yu Kuai
2022-11-29 2:15 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8280fa32-4a96-be98-06ac-1890f95f026f@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=jack@suse.cz \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).