Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Zhangguanghui <zhang.guanghui@h3c.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	James Smart <jsmart2021@gmail.com>
Subject: Re: scsi: lpfc: Fix hardlockup in lpfc_abort_handler
Date: Thu, 10 Oct 2019 10:49:50 -0700
Message-ID: <834b8a8d-8c08-0903-852d-7387e2331533@gmail.com> (raw)
In-Reply-To: <d06924929def46d2bfca19a5cf2e7b55@h3c.com>

On 10/10/2019 1:59 AM, Zhangguanghui wrote:
> Hi everyone
> 
> Please refer to the latest patch.
> 
> There is a race deadlock in the function lpfc_abort_handler
> 
> potential deadlocks arising from lock ordering problems.
> 
> It’s the correct order
> 
> spin_unlock(&lpfc_cmd->buf_lock)
> 
> spin_unlock_irqrestore(&phba->hbalock, flags);
> 
> How to solve it ? I think that the patch is reasonable,
> 
> can you help me review and commit this patch, Best regards
> 
> diff --git a/src/lpfc-12.2.0.0/lpfc_scsi.c b/src/lpfc-12.2.0.0/lpfc_scsi.c
> 
> index 3f1375a..19c8505 100644
> 
> --- a/src/lpfc-12.2.0.0/lpfc_scsi.c
> 
> +++ b/src/lpfc-12.2.0.0/lpfc_scsi.c
> 

We confirmed the issue you stated.  We are looking at what you proposed 
and will be adding a patch that will be posted in our next
patch set after we've put it through some regression testing.

-- james


           reply index

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <d06924929def46d2bfca19a5cf2e7b55@h3c.com>]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834b8a8d-8c08-0903-852d-7387e2331533@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=zhang.guanghui@h3c.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org linux-scsi@archiver.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox