From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
Khazhismel Kumykov <khazhy@google.com>,
cleech@redhat.com, lduncan@suse.com, kernel@collabora.com
Subject: Re: [PATCH v2] iscsi: Fix deadlock on recovery path during GFP_IO reclaim
Date: Tue, 26 May 2020 22:23:13 -0400 [thread overview]
Message-ID: <85imgiyv3i.fsf@collabora.com> (raw)
In-Reply-To: <159054550935.12032.12429490681572583579.b4-ty@oracle.com> (Martin K. Petersen's message of "Tue, 26 May 2020 22:12:58 -0400")
"Martin K. Petersen" <martin.petersen@oracle.com> writes:
> On Tue, 19 May 2020 22:29:59 -0400, Gabriel Krisman Bertazi wrote:
>
>> iscsi suffers from a deadlock in case a management command submitted via
>> the netlink socket sleeps on an allocation while holding the
>> rx_queue_mutex, if that allocation causes a memory reclaim that
>> writebacks to a failed iscsi device. Then, the recovery procedure can
>> never make progress to recover the failed disk or abort outstanding IO
>> operations to complete the reclaim (since rx_queue_mutex is locked),
>> thus locking the system.
>>
>> [...]
>
> Applied to 5.8/scsi-queue, thanks!
>
> [1/1] scsi: iscsi: Fix deadlock on recovery path during GFP_IO reclaim
> https://git.kernel.org/mkp/scsi/c/7e7cd796f277
Thanks, Martin!
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2020-05-27 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 2:29 [PATCH v2] iscsi: Fix deadlock on recovery path during GFP_IO reclaim Gabriel Krisman Bertazi
2020-05-27 2:12 ` Martin K. Petersen
2020-05-27 2:23 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85imgiyv3i.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=cleech@redhat.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).