From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux@yadro.com" <linux@yadro.com>,
Nilesh Javali <njavali@marvell.com>, Chris Boot <bootc@bootc.net>,
Bart Van Assche <bvanassche@acm.org>,
Michael Cyr <mikecyr@linux.ibm.com>,
Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v2 0/7] target: make tpg/enable attribute
Date: Mon, 22 Mar 2021 14:49:20 +0000 [thread overview]
Message-ID: <8F4C2C39-8182-44F4-B20D-90CF5B518EFD@oracle.com> (raw)
In-Reply-To: <20210322080554.7611-1-d.bogdanov@yadro.com>
> On Mar 22, 2021, at 3:05 AM, Dmitry Bogdanov <d.bogdanov@yadro.com> wrote:
>
> Many fabric modules provide their own implementation of enable
> attribute in tpg.
> The change set removes the code duplication and automatically adds "enable"
> attribute for fabric modules that has an implementation of
> fabric_enable_tpg() ops.
>
> This patchset is intended for scsi-queue.
>
> v2:
> create enable atribute only for modules with enable_tpg ops
> add patches for srpt, usb and ibmvscsi
>
> Dmitry Bogdanov (7):
> target: core: add common tpg/enable attribute
> target: iscsi: replace enable attr to ops.enable
> target: qla2xx: replace enable attr to ops.enable
> target: sbp: replace enable attr to ops.enable
> target: srpt replace enable attr to ops.enable
> target: ibm_vscsi: replace enable attr to ops.enable
> target: usb: replace enable attr to ops.enable
>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 38 +-------
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 42 +--------
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 73 +++-------------
> drivers/target/iscsi/iscsi_target_configfs.c | 91 +++++++-------------
> drivers/target/sbp/sbp_target.c | 30 ++-----
> drivers/target/target_core_configfs.c | 1 +
> drivers/target/target_core_fabric_configfs.c | 40 ++++++++-
> drivers/target/target_core_internal.h | 1 +
> drivers/target/target_core_tpg.c | 41 +++++++++
> drivers/usb/gadget/function/f_tcm.c | 31 ++-----
> include/target/target_core_base.h | 1 +
> include/target/target_core_fabric.h | 1 +
> 12 files changed, 146 insertions(+), 244 deletions(-)
>
> --
> 2.25.1
>
Series looks good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
prev parent reply other threads:[~2021-03-22 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 8:05 [PATCH v2 0/7] target: make tpg/enable attribute Dmitry Bogdanov
2021-03-22 8:05 ` [PATCH v2 1/7] target: core: add common " Dmitry Bogdanov
2021-03-22 17:35 ` Mike Christie
2021-03-22 17:55 ` Dmitriy Bogdanov
2021-03-24 21:51 ` Konstantin Shelekhin
2021-03-22 8:05 ` [PATCH v2 2/7] target: iscsi: replace enable attr to ops.enable Dmitry Bogdanov
2021-03-22 17:43 ` Mike Christie
2021-03-22 8:05 ` [PATCH v2 3/7] target: qla2xx: " Dmitry Bogdanov
2021-03-22 8:05 ` [PATCH v2 4/7] target: sbp: " Dmitry Bogdanov
2021-03-22 8:05 ` [PATCH v2 5/7] target: srpt " Dmitry Bogdanov
2021-03-22 8:05 ` [PATCH v2 6/7] target: ibm_vscsi: " Dmitry Bogdanov
2021-03-22 8:05 ` [PATCH v2 7/7] target: usb: " Dmitry Bogdanov
2021-03-22 14:49 ` Himanshu Madhani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F4C2C39-8182-44F4-B20D-90CF5B518EFD@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=balbi@kernel.org \
--cc=bootc@bootc.net \
--cc=bvanassche@acm.org \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=mikecyr@linux.ibm.com \
--cc=njavali@marvell.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).