From: Damien Le Moal <firstname.lastname@example.org> To: Tom Yan <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Greg KH <email@example.com> Subject: Re: [Regression][Stable] sd use scsi_mode_sense with invalid param Date: Sat, 27 Nov 2021 10:15:51 +0900 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAGnHSEmkTyq_QqP9S6TemsHOKxj2Gzq3R7X6+PxbQs_R-iBB7Q@mail.gmail.com> On 2021/11/27 6:33, Tom Yan wrote: > Hi Greg, > > Could you help pulling c749301ebee82eb5e97dec14b6ab31a4aabe37a6 into > the stable branches in which 17b49bcbf8351d3dbe57204468ac34f033ed60bc > has been pulled? Thanks! Yeah, in retrospect, these 2 patches should really have been squashed together. Sorry about that. Note that none of these were marked for stable though. I think that Sasha's bot picked-up automatically 17b49bcbf8351d3dbe57204468ac34f033ed60bc for stable because of the "Fix" in the commit title. But c749301ebee82eb5e97dec14b6ab31a4aabe37a6 also has "Fix" in its title but was not picked-up. Weird. Greg, Martin, To fix this, c749301ebee82eb5e97dec14b6ab31a4aabe37a6 is needed in stable ! Reference: https://bugzilla.kernel.org/show_bug.cgi?id=215137 Thanks. > > Regards, > Tom > > On Sat, 27 Nov 2021 at 05:21, Tom Yan <email@example.com> wrote: >> >> Ahh, looks like the required change to sd >> (c749301ebee82eb5e97dec14b6ab31a4aabe37a6) has been added to upstream >> but somehow got missed when 17b49bcbf8351d3dbe57204468ac34f033ed60bc >> was pulled into stable... >> >> On Sat, 27 Nov 2021 at 05:11, Tom Yan <firstname.lastname@example.org> wrote: >>> >>> Hi, >>> >>> So with 17b49bcbf8351d3dbe57204468ac34f033ed60bc (upstream), >>> scsi_mode_sense now returns -EINVAL if len < 8, yet in sd, the first mode >>> sense attempted by sd_read_cache_type() is done with (first_)len being >>> 4, which results in the failure of the attempt. >>> >>> Since the commit is merged into stable, my SATA drive (that has >>> volatile write cache) is assumed to be a "write through" drive after I >>> upgraded from 5.15.4 to 5.15.5, as libata sets use_10_for_ms to 1. >>> >>> Since sd does not (get to) determine which mode sense command to use, >>> should scsi_mode_sense at least accept a special value 0 (which >>> first_len would be set to), which is use to refers to the minimum len >>> to use for mode sense 6 and 10 respectively (i.e. 4 or 8)? >>> >>> Regards, >>> Tom -- Damien Le Moal Western Digital Research
next prev parent reply other threads:[~2021-11-27 1:17 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-26 21:11 Tom Yan 2021-11-26 21:21 ` Tom Yan 2021-11-26 21:33 ` Tom Yan 2021-11-27 1:15 ` Damien Le Moal [this message] 2021-11-27 11:55 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [Regression][Stable] sd use scsi_mode_sense with invalid param' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).