From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Daniel Wagner <dwagner@suse.de>, linux-scsi@vger.kernel.org
Cc: Arun Easi <aeasi@marvell.com>,
Nilesh Javali <njavali@marvell.com>,
Hannes Reinecke <hare@suse.de>, Martin Wilck <mwilck@suse.com>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
Date: Wed, 20 May 2020 11:41:33 -0500 [thread overview]
Message-ID: <93e0ca46-06ea-6e89-5078-5f78f02db653@oracle.com> (raw)
In-Reply-To: <20200520130819.90625-1-dwagner@suse.de>
Daniel,
On 5/20/20 8:08 AM, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
>
> Signed-off-by: Daniel Wagner<dwagner@suse.de>
> ---
Good Catch.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2020-05-20 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
2020-05-20 13:36 ` Johannes Thumshirn
2020-05-20 15:51 ` Bart Van Assche
2020-05-20 16:03 ` Roman Bolshakov
2020-05-20 16:41 ` Himanshu Madhani [this message]
2020-05-27 2:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e0ca46-06ea-6e89-5078-5f78f02db653@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=aeasi@marvell.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).