From: Can Guo <cang@codeaurora.org>
To: Bean Huo <huobean@gmail.com>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] scsi: ufs: Use UPIU query trace in devman_upiu_cmd
Date: Fri, 04 Jun 2021 10:36:59 +0800 [thread overview]
Message-ID: <9526e2c0646f8755756be5b712e5bb2a@codeaurora.org> (raw)
In-Reply-To: <aaa62a02184b590c8845183c4bbad9a0e9ab36aa.camel@gmail.com>
On 2021-06-03 05:05, Bean Huo wrote:
> On Wed, 2021-06-02 at 10:29 +0800, Can Guo wrote:
>> > spin_lock_irqsave(hba->host->host_lock, flags);
>> > @@ -6732,6 +6733,8 @@ static int
>> > ufshcd_issue_devman_upiu_cmd(struct
>> > ufs_hba *hba,
>> > err = -EINVAL;
>> > }
>> > }
>> > + ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR :
>> > UFS_QUERY_COMP,
>> > + (struct utp_upiu_req *)lrbp-
>> > >ucd_rsp_ptr);
>> > out:
>> > blk_put_request(req);
>>
>>
>> What about ufshcd_exec_dev_cmd()?
>>
>
>
> Can,
> thanks for your veiew.
> yes, ufshcd_exec_dev_cmd() is only to send
> UPIU command frame, and doesn't include CDB. It already uses
> ufshcd_add_query_upiu_trace() to trace UPIU frame.
>
Oh, sorry, I missed it.
Reviewed-by: Can Guo <cang@codeaurora.org>
> Kind regards,
> Bean
>
>> Thanks,
>>
>> Can Guo.
next prev parent reply other threads:[~2021-06-04 2:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 10:43 [PATCH v2 0/4] Several minor changes for UFS Bean Huo
2021-05-31 10:43 ` [PATCH v2 1/4] scsi: ufs: Cleanup ufshcd_add_command_trace() Bean Huo
2021-06-02 2:35 ` Can Guo
2021-05-31 10:43 ` [PATCH v2 2/4] scsi: ufs: Let UPIU completion trace print RSP UPIU header Bean Huo
2021-06-02 2:34 ` Can Guo
2021-05-31 10:43 ` [PATCH v2 3/4] scsi: ufs: Let command trace only for the cmd != null case Bean Huo
2021-06-02 2:32 ` Can Guo
2021-05-31 10:43 ` [PATCH v2 4/4] scsi: ufs: Use UPIU query trace in devman_upiu_cmd Bean Huo
2021-06-02 2:29 ` Can Guo
2021-06-02 21:05 ` Bean Huo
2021-06-04 2:36 ` Can Guo [this message]
2021-06-08 2:36 ` [PATCH v2 0/4] Several minor changes for UFS Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9526e2c0646f8755756be5b712e5bb2a@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).