From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <jthumshirn@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v3 5/7] block: Delay default elevator initialization
Date: Thu, 5 Sep 2019 04:30:36 +0000 [thread overview]
Message-ID: <BYAPR04MB58166AA744FE3A240050BAC1E7BB0@BYAPR04MB5816.namprd04.prod.outlook.com> (raw)
In-Reply-To: 68bd56dd-46cf-efa3-14f2-4f8e50ac15c0@kernel.dk
On 2019/09/04 21:57, Jens Axboe wrote:
> On 9/4/19 3:02 AM, Damien Le Moal wrote:
>> On 2019/09/04 17:56, Johannes Thumshirn wrote:
>>> On 04/09/2019 10:42, Damien Le Moal wrote:
>>>> @@ -734,6 +741,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
>>>> exact_match, exact_lock, disk);
>>>> }
>>>> register_disk(parent, disk, groups);
>>>> +
>>>> if (register_queue)
>>>> blk_register_queue(disk);
>>>
>>> That hunk looks unrelated, but anyways:
>>> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>>
>> Oops. Yes, did not delete the blank line when I moved elevator_init_mq() call.
>> Jens, should I resend a v4 to fix this ?
>
> Series looks good to me, I'll just delete this one hunk, not a big deal.
>
Jens,
Thanks. But Ming's comment needed to be addressed, which I did in the V4 I just
sent out. I removed the white line chunk too.
Best regards.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2019-09-05 4:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:42 [PATCH v3 0/7] Elevator cleanups and improvements Damien Le Moal
2019-09-04 8:42 ` [PATCH v3 1/7] block: Cleanup elevator_init_mq() use Damien Le Moal
2019-09-04 9:02 ` Ming Lei
2019-09-04 8:42 ` [PATCH v3 2/7] block: Change elevator_init_mq() to always succeed Damien Le Moal
2019-09-04 9:05 ` Ming Lei
2019-09-04 8:42 ` [PATCH v3 3/7] block: Introduce elevator features Damien Le Moal
2019-09-04 8:42 ` [PATCH v3 4/7] block: Improve default elevator selection Damien Le Moal
2019-09-04 8:51 ` Johannes Thumshirn
2019-09-04 8:42 ` [PATCH v3 5/7] block: Delay default elevator initialization Damien Le Moal
2019-09-04 8:56 ` Johannes Thumshirn
2019-09-04 9:02 ` Damien Le Moal
2019-09-04 12:56 ` Jens Axboe
2019-09-05 4:30 ` Damien Le Moal [this message]
2019-09-04 9:29 ` Ming Lei
2019-09-04 8:42 ` [PATCH v3 6/7] block: Set ELEVATOR_F_ZBD_SEQ_WRITE for nullblk zoned disks Damien Le Moal
2019-09-04 8:52 ` Johannes Thumshirn
2019-09-04 8:42 ` [PATCH v3 7/7] sd: Set ELEVATOR_F_ZBD_SEQ_WRITE for ZBC disks Damien Le Moal
2019-09-04 8:52 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB58166AA744FE3A240050BAC1E7BB0@BYAPR04MB5816.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).