From: Nitesh Lal <nilal@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
huangguangbin2@huawei.com, huangdaode@huawei.com,
Frederic Weisbecker <frederic@kernel.org>,
Alex Belits <abelits@marvell.com>,
Bjorn Helgaas <bhelgaas@google.com>,
rostedt@goodmis.org, Peter Zijlstra <peterz@infradead.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Ingo Molnar <mingo@kernel.org>,
jbrandeb@kernel.org, akpm@linuxfoundation.org,
sfr@canb.auug.org.au, stephen@networkplumber.org,
rppt@linux.vnet.ibm.com, chris.friesen@windriver.com,
Marc Zyngier <maz@kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
pjwaskiewicz@gmail.com, Stefan Assmann <sassmann@redhat.com>,
Tomas Henzl <thenzl@redhat.com>,
james.smart@broadcom.com, Ken Cox <jkc@redhat.com>,
faisal.latif@intel.com, shiraz.saleem@intel.com,
tariqt@nvidia.com, Alaa Hleihel <ahleihel@redhat.com>,
Kamal Heib <kheib@redhat.com>,
borisp@nvidia.com, saeedm@nvidia.com, "Nikolova,
Tatyana E" <tatyana.e.nikolova@intel.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
Al Stone <ahs3@redhat.com>, Leon Romanovsky <leonro@nvidia.com>,
Chandrakanth Patil <chandrakanth.patil@broadcom.com>,
bjorn.andersson@linaro.org, chunkuang.hu@kernel.org,
yongqiang.niu@mediatek.com, baolin.wang7@gmail.com,
Petr Oros <poros@redhat.com>, Ming Lei <minlei@redhat.com>,
Ewan Milne <emilne@redhat.com>,
jejb@linux.ibm.com, kabel@kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Jakub Kicinski <kuba@kernel.org>,
kashyap.desai@broadcom.com,
Sumit Saxena <sumit.saxena@broadcom.com>,
shivasharan.srikanteshwara@broadcom.com,
sathya.prakash@broadcom.com,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
suganath-prabu.subramani@broadcom.com, ley.foon.tan@intel.com,
jbrunet@baylibre.com, johannes@sipsolutions.net,
snelson@pensando.io, lewis.hanly@microchip.com, benve@cisco.com,
_govind@gmx.com, jassisinghbrar@gmail.com
Subject: Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
Date: Fri, 10 Dec 2021 08:51:39 -0500 [thread overview]
Message-ID: <CAFki+L=5sLN+nU+YpSSrQN0zkAOKrJorevm0nQ+KdwCpnOzf3w@mail.gmail.com> (raw)
In-Reply-To: <CAFki+Lmrv-UjZpuTQWr9c-Rymfm-tuCw9WpwmHgyfjVhJgp--g@mail.gmail.com>
Hi Martin,
On Wed, Nov 24, 2021 at 5:16 PM Nitesh Lal <nilal@redhat.com> wrote:
>
> On Wed, Nov 24, 2021 at 2:30 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > Nitesh,
> >
> > On Mon, Sep 13 2021 at 10:34, Nitesh Lal wrote:
> > > On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
> > >>
> > >> The drivers currently rely on irq_set_affinity_hint() to either set the
> > >> affinity_hint that is consumed by the userspace and/or to enforce a custom
> > >> affinity.
> > >>
> > >> irq_set_affinity_hint() as the name suggests is originally introduced to
> > >> only set the affinity_hint to help the userspace in guiding the interrupts
> > >> and not the affinity itself. However, since the commit
> > >>
> > >> e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
> >
> > sorry for ignoring this. It fell through the cracks.
>
>
> No worries, thank you for reviewing.
>
> >
> >
> > >> Thomas Gleixner (1):
> > >> genirq: Provide new interfaces for affinity hints
> >
> > Did I actually write this?
>
>
> Yeap, the idea and the initial patch came from you. :)
>
> >
> >
> > > Any suggestions on what should be the next steps here? Unfortunately, I haven't
> > > been able to get any reviews on the following two patches:
> > > be2net: Use irq_update_affinity_hint
> > > hinic: Use irq_set_affinity_and_hint
> > >
> > > One option would be to proceed with the remaining patches and I can try
> > > posting these two again when I post patches for the remaining drivers?
> >
> > The more general question is whether I should queue all the others or
> > whether some subsystem would prefer to pull in a tagged commit on top of
> > rc1. I'm happy to carry them all of course.
> >
>
> I am fine either way.
> In the past, while I was asking for more testing help I was asked if the
> SCSI changes are part of Martins's scsi-fixes tree as that's something
> Broadcom folks test to check for regression.
> So, maybe Martin can pull this up?
>
Gentle ping.
Any thoughts on the above query?
--
Thanks
Nitesh
next prev parent reply other threads:[~2021-12-10 13:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 03/14] i40e: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 07/14] enic: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 08/14] be2net: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 09/14] ixgbe: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 10/14] mailbox: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 13/14] net/mlx5: " Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-09-13 14:34 ` [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal
2021-11-24 19:30 ` Thomas Gleixner
2021-11-24 22:16 ` Nitesh Lal
2021-12-10 13:51 ` Nitesh Lal [this message]
2021-12-10 18:44 ` Thomas Gleixner
2021-12-10 18:54 ` Nitesh Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFki+L=5sLN+nU+YpSSrQN0zkAOKrJorevm0nQ+KdwCpnOzf3w@mail.gmail.com' \
--to=nilal@redhat.com \
--cc=_govind@gmx.com \
--cc=abelits@marvell.com \
--cc=ahleihel@redhat.com \
--cc=ahs3@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akpm@linuxfoundation.org \
--cc=baolin.wang7@gmail.com \
--cc=benve@cisco.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=borisp@nvidia.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=chris.friesen@windriver.com \
--cc=chunkuang.hu@kernel.org \
--cc=davem@davemloft.net \
--cc=dick.kennedy@broadcom.com \
--cc=emilne@redhat.com \
--cc=faisal.latif@intel.com \
--cc=frederic@kernel.org \
--cc=huangdaode@huawei.com \
--cc=huangguangbin2@huawei.com \
--cc=james.smart@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=jbrandeb@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jejb@linux.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=jkc@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=juri.lelli@redhat.com \
--cc=kabel@kernel.org \
--cc=kashyap.desai@broadcom.com \
--cc=kheib@redhat.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=lewis.hanly@microchip.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=minlei@redhat.com \
--cc=mtosatti@redhat.com \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=pjwaskiewicz@gmail.com \
--cc=poros@redhat.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=saeedm@nvidia.com \
--cc=sassmann@redhat.com \
--cc=sathya.prakash@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=shiraz.saleem@intel.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=snelson@pensando.io \
--cc=somnath.kotur@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=tglx@linutronix.de \
--cc=thenzl@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).