From: Julian Calaby <julian.calaby@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sumit Saxena <sumit.saxena@broadcom.com>,
Markus Elfring <Markus.Elfring@web.de>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@broadcom.com>,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Chandrakanth Patil <chandrakanth.patil@broadcom.com>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH] scsi: megaraid_sas: Use common error handling code in megasas_mgmt_ioctl_fw()
Date: Tue, 5 Nov 2019 21:20:25 +1100 [thread overview]
Message-ID: <CAGRGNgU9=Ng60QE_-f8fs5HzDTFQ_8R3taidERAocBc1nQwbXg@mail.gmail.com> (raw)
In-Reply-To: <20191105093641.GE10409@kadam>
Hi,
On Tue, Nov 5, 2019 at 8:41 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Tue, Nov 05, 2019 at 02:58:35PM +0530, Sumit Saxena wrote:
> > On Fri, Nov 1, 2019 at 3:06 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > >
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Thu, 31 Oct 2019 22:23:02 +0100
> > >
> > > Move the same error code assignments so that such exception handling
> > > can be better reused at the end of this function.
> > >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> >
> > Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
> >
>
> The code was a lot better originally... :(
Agreed, this is a lot of stuffing around to save 3 lines.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
prev parent reply other threads:[~2019-11-05 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:35 [PATCH] scsi: megaraid_sas: Use common error handling code in megasas_mgmt_ioctl_fw() Markus Elfring
2019-11-05 9:28 ` Sumit Saxena
2019-11-05 9:36 ` Dan Carpenter
2019-11-05 10:20 ` Julian Calaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRGNgU9=Ng60QE_-f8fs5HzDTFQ_8R3taidERAocBc1nQwbXg@mail.gmail.com' \
--to=julian.calaby@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=chandrakanth.patil@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).