From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3FBEC433FF for ; Tue, 13 Aug 2019 22:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF0CD20665 for ; Tue, 13 Aug 2019 22:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfHMWKZ (ORCPT ); Tue, 13 Aug 2019 18:10:25 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:45840 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfHMWKY (ORCPT ); Tue, 13 Aug 2019 18:10:24 -0400 Received: by mail-vs1-f66.google.com with SMTP id h28so73240935vsl.12; Tue, 13 Aug 2019 15:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iTOCmMlUQI4Ou/DijdBIjbiZAWNFSaKrQKnKPO3XY8o=; b=TUXM+SPFHY3k76fw8TXX2rhKycxcNktfOaZmgKU4b05jYMOsBfnQTSa6wAGSzcquwc MvbBrJYiikbfk6Dc9dpqyEpUJFj5lG/DH3wT0dcXqDlKjhP2wLCdrS3sLblnypg1S1KW n3wCmdf970WgN5xOMzjyoxG+7MDhsDFKt4MDdqPcEipKympffRDhsN2tYcWFtDqdlZKL Bk+gEc+Ez6IUOcISTpI99hlEKKUpQCNErgLyh4+Qic3zFwvDzXiKc2YGF0iGL7hqjSHM uJ1wk1qJLMr1fhR1VXlxpHjW5NpZiIsm93WCxN5G3zqbFllSpm7sYPIEA/PDZHWCFCLv SWLw== X-Gm-Message-State: APjAAAXsbQjFexFM55EVRuyVPjWaKNGH+pM4JcZ1MwpmJKlxQywOcQa0 mST90q5rX68b1vg3L3etjS9HKzBUEDWCogrkif8= X-Google-Smtp-Source: APXvYqz0UYBfkcWb8zAzxB0wr6Gyxnzd4i5JutnFy3WCLJjC4APDP1rokNzg6YVyPjaXbINByjUSBwqnadpRO9ZhE9M= X-Received: by 2002:a67:cd09:: with SMTP id u9mr26551154vsl.222.1565734223495; Tue, 13 Aug 2019 15:10:23 -0700 (PDT) MIME-Version: 1.0 References: <20190809002104.18599-1-stancheff@cray.com> <20190809002104.18599-2-stancheff@cray.com> In-Reply-To: From: Shaun Tancheff Date: Tue, 13 Aug 2019 17:10:12 -0500 Message-ID: Subject: Re: [PATCH 1/1] kbuild: recursive build of external kernel modules To: Masahiro Yamada Cc: Shaun Tancheff , Linux Kbuild mailing list , Joe Lawrence , "James E . J . Bottomley" , Jonathan Corbet , "Martin K . Petersen" , Michal Marek , Shuah Khan , Thomas Renninger , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux PM mailing list , linux-scsi Content-Type: text/plain; charset="UTF-8" Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Aug 12, 2019 at 8:07 PM Masahiro Yamada wrote: > > On Tue, Aug 13, 2019 at 2:34 AM Shaun Tancheff wrote: > > > > On Mon, Aug 12, 2019 at 10:24 AM Masahiro Yamada > > wrote: > > > > > > On Fri, Aug 9, 2019 at 9:21 AM Shaun Tancheff wrote: > > > > > > > > When building a tree of external modules stage 2 fails > > > > silently as the root modules.order is empty. > > > > > > > > Modify the modules.order location to be fixed to the > > > > root when KBUILD_EXTMOD is specified and write all > > > > module paths to the single modules.order file. > > > > > > Could you try v5.3-rc4 please? > > > > So it seems we are using 'subdir-m' but that is now gone? > > > > Is there a recommend pattern for backward compatibility? > > > > Thanks! > > > Please convert > > subdir-m += dir1 > subdir-m += dir2 > > into > > obj-m += dir1/ > obj-m += dir2/ After working through some local quirks everything is working now. Thanks! > > > Thanks. > > -- > Best Regards > Masahiro Yamada