From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDB58C433E0 for ; Fri, 15 Jan 2021 10:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 761B3235F9 for ; Fri, 15 Jan 2021 10:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbhAOKe2 (ORCPT ); Fri, 15 Jan 2021 05:34:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbhAOKe1 (ORCPT ); Fri, 15 Jan 2021 05:34:27 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFD3EC0613C1 for ; Fri, 15 Jan 2021 02:33:47 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id by27so8953833edb.10 for ; Fri, 15 Jan 2021 02:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7LLY4cPoj6ptHG8TMYZijdPTmBW8T6G4b89+HyQKpxw=; b=GE0cXLy/kuL2fZZ4/IVlnZ4FCfpmQzodiSicwAJ2UPtRyR+BZKUSvETds02GbcRAka D2WgvVnDzqUE+Xn+V4UXj+yTN2YiwA/gPMzM6Rk0NZQ5oWGu+wJDKvia1gufFft673sm A5xTHv86/iXYeRbn2cA/AdWq8wKWhyE6U0PAASysIRur2uXiSJ29dxtoM7UtUC3LdlsU W9hBCrC5kYFiuqv67DvWW/R/CfoYZIiGm6g4/7NwjxLE+q3h07YsyE586wQpqovV6PHS +hS+ZU9Lu3QzBw8S8Mwn9jFhXVgL3yJqPKiRCQILXIK8oUi+jdmcSRaiTtQL3cMkpyFV +LLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7LLY4cPoj6ptHG8TMYZijdPTmBW8T6G4b89+HyQKpxw=; b=JQ37aSwznbr1hrQ4uzUtQ8+jMEBHDq7y89ZlCrU5UA69lbPhs/RloJLzslvu6HDzLE rRojarc5C3HqqZekAjR5xfqLPmPpFxAQC6uQAmASeBzKAKHyJfzKS5FbC6PU84TWWD5Z dCnotu5vYBoBdRxdC/fIMOwVqab9aCDi3zO3e4llvqHKiHt5QtLHSBqMHTJaSzpww9e+ aZyeZ4umb922nZnlC036fhqRdl60xo1svEItU0xLeCOpghvpP+0psl8QtlcQc9A635GZ TwLFbCVo48+BpYcieoMvePVtWL99m1iQGQvHvZT520/65j9lj2fUt6+Rd5cb/7cagJOX +CIg== X-Gm-Message-State: AOAM5307eqGQxQOvrAC51vXDg3m6DNA6BDK5t9OagUinV680+QGQRG5D 9suzLTlHav6RGkSCx+y0mncUYGlk/M7JQ6nXtRHvhg== X-Google-Smtp-Source: ABdhPJx/EV3I7aklh2GfUFN/kPHVBFAEjZgJJRD4iG4LA1RbEIWCLSURQbBMV94N4R34LBDU7RFHq4FkOSXKkeciUP8= X-Received: by 2002:a05:6402:a53:: with SMTP id bt19mr9206928edb.104.1610706826562; Fri, 15 Jan 2021 02:33:46 -0800 (PST) MIME-Version: 1.0 References: <20210115095824.9170-1-colin.king@canonical.com> In-Reply-To: <20210115095824.9170-1-colin.king@canonical.com> From: Jinpu Wang Date: Fri, 15 Jan 2021 11:33:35 +0100 Message-ID: Subject: Re: [PATCH][next] scsi: pm80xx: clean up indentation of a code block To: Colin King Cc: "James E . J . Bottomley" , "Martin K . Petersen" , Linux SCSI Mailinglist , kernel-janitors@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Jan 15, 2021 at 10:58 AM Colin King wrote: > > From: Colin Ian King > > A block of code is indented one level too deeply, clean this > up. > > Addresses-Coverity: ("Indentation does not match nesting level") > Signed-off-by: Colin Ian King Acked-by: Jack Wang > --- > drivers/scsi/pm8001/pm80xx_hwi.c | 34 ++++++++++++++------------------ > 1 file changed, 15 insertions(+), 19 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c > index e7fef42b4f6c..6fd206abc9fc 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -358,26 +358,22 @@ ssize_t pm80xx_get_fatal_dump(struct device *cdev, > MEMBASE_II_SHIFT_REGISTER, > pm8001_ha->fatal_forensic_shift_offset); > } > - /* Read the next block of the debug data.*/ > - length_to_read = pm8001_mr32(fatal_table_address, > - MPI_FATAL_EDUMP_TABLE_ACCUM_LEN) - > - pm8001_ha->forensic_preserved_accumulated_transfer; > - if (length_to_read != 0x0) { > - pm8001_ha->forensic_fatal_step = 0; > - goto moreData; > - } else { > - pm8001_ha->forensic_info.data_buf.direct_data += > - sprintf( > - pm8001_ha->forensic_info.data_buf.direct_data, > + /* Read the next block of the debug data.*/ > + length_to_read = pm8001_mr32(fatal_table_address, > + MPI_FATAL_EDUMP_TABLE_ACCUM_LEN) - > + pm8001_ha->forensic_preserved_accumulated_transfer; > + if (length_to_read != 0x0) { > + pm8001_ha->forensic_fatal_step = 0; > + goto moreData; > + } else { > + pm8001_ha->forensic_info.data_buf.direct_data += > + sprintf(pm8001_ha->forensic_info.data_buf.direct_data, > "%08x ", 4); > - pm8001_ha->forensic_info.data_buf.read_len > - = 0xFFFFFFFF; > - pm8001_ha->forensic_info.data_buf.direct_len > - = 0; > - pm8001_ha->forensic_info.data_buf.direct_offset > - = 0; > - pm8001_ha->forensic_info.data_buf.read_len = 0; > - } > + pm8001_ha->forensic_info.data_buf.read_len = 0xFFFFFFFF; > + pm8001_ha->forensic_info.data_buf.direct_len = 0; > + pm8001_ha->forensic_info.data_buf.direct_offset = 0; > + pm8001_ha->forensic_info.data_buf.read_len = 0; > + } > } > offset = (int)((char *)pm8001_ha->forensic_info.data_buf.direct_data > - (char *)buf); > -- > 2.29.2 >