From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1052C2D0C1 for ; Thu, 19 Dec 2019 14:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96ED824672 for ; Thu, 19 Dec 2019 14:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GcIQFBxC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbfLSOZb (ORCPT ); Thu, 19 Dec 2019 09:25:31 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:33496 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbfLSOZb (ORCPT ); Thu, 19 Dec 2019 09:25:31 -0500 Received: by mail-io1-f67.google.com with SMTP id z8so5942570ioh.0; Thu, 19 Dec 2019 06:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7XnF/uehLL84V1vkG+Snc8Ul1hkW/yuH+aVf155kbS4=; b=GcIQFBxCUDQnZv4JORlyc6AJAPDoWIQkad1VCZEHwSk4CYCaxgaaELYyObtNudWhLu DdqB1OgWOg7zyTGLuXc2wSMF/OnK6lRWfPoo8YIhk5RLr0PJBzNni0QC77pIzgniqzHp kN5C71xyD/btbzMeAIjkFUB7RHSYr+0pZJrQmp/orAw2GP5W4b0vzx7ZasU4r/y6+ir8 LNOGignP3BcqPOW0+OpmSE4YL0IpMC4A51+QkOY5id+Em5nC/fUdSA9DP+Sy3mtygF4D 0qgUkjGjnAYr5d5+FWh8QG5K0zrTTFrqtx8Y4NDcb+nNyW9vEt1y0ivEleN3djCsMBNW X57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7XnF/uehLL84V1vkG+Snc8Ul1hkW/yuH+aVf155kbS4=; b=Hjp6QmYJrrw2VRid1IgeVbX77gJUcRVtOdMScHnbv3LCjKHsfd3J+yR2NHIDkbqjxh mVeSiIwLlnli/uJj1GEyZtiZNm2UM2XCSb71yjQ4i5JmuXmj7Kdb6P9/I/7VXvkcy5ug XPGcjliKj+GwTvaDRG6x4wytZO7UgzFA6vqp0D0XGOX4QFAO82DTKdaFbMIkwnnyeA+I LJAZ4hghtfghJ/Bws/uEu0ctZwo446RsSp2V2eVXAAMPoF2KL7vd1ODKCkEg/PqRIO2+ KBV3QHsy2ON6ZZC4d7e2QcUyDkbqnrl6tgxQoNsev2QGOjLZq9wCJnfXZPxl5HAFv5ru DiFg== X-Gm-Message-State: APjAAAU9uaSeFdUj39jyYtV36G7nlP2RORt6fDg7vSza6Cxmem562oFY WtJWVicjsVrvdoQyboFfs7ADRcV6emzV8uvQj9o= X-Google-Smtp-Source: APXvYqxV8p46grVHwtLDZow1CVwGexIWq2/WeOp2R1mxJR2VAMQLIcTNTaK0Otep4R6omcV1hDFNmaAuZfn2Fm9RcS0= X-Received: by 2002:a5d:9c4e:: with SMTP id 14mr6220184iof.166.1576765530409; Thu, 19 Dec 2019 06:25:30 -0800 (PST) MIME-Version: 1.0 References: <091562cbe7d88ca1c30638bc10197074@codeaurora.org> <20191217041342.GM2536@vkoul-mobl> <763d7b30593b31646f3c198c2be99671@codeaurora.org> <20191217092433.GN2536@vkoul-mobl> <20191217150852.GO2536@vkoul-mobl> <75f7065d08f450c6cbb2b2662658ecaa@codeaurora.org> <20191218041200.GP2536@vkoul-mobl> <983c21bb5ad2d38e11c074528d8898b9@codeaurora.org> <20191219142145.GV2536@vkoul-mobl> In-Reply-To: <20191219142145.GV2536@vkoul-mobl> From: Jeffrey Hugo Date: Thu, 19 Dec 2019 07:25:19 -0700 Message-ID: Subject: Re: [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller To: Vinod Koul Cc: Can Guo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, Rajendra Nayak , linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, Mark Salyzyn , Andy Gross , Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Thu, Dec 19, 2019 at 7:21 AM Vinod Koul wrote: > > On 19-12-19, 15:12, cang@codeaurora.org wrote: > > On 2019-12-18 12:12, Vinod Koul wrote: > > > On 18-12-19, 02:44, cang@codeaurora.org wrote: > > > > > Aside of the phy settings, your DT needs some modifications too, > > seems you copied most of them from sdm845. > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=3834a2e92229ef26d30de28acb698b2b23d3e397 > > > > <--snip--> > > > + ufs_mem_phy: phy@1d87000 { > > > + compatible = "qcom,sm8150-qmp-ufs-phy"; > > > + reg = <0 0x01d87000 0 0x18c>; > > > > The size 0x18c is wrong, in the code you are even accessing registers > > whose offsets are beyond 0x18c, see > > > > #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x1ac > > #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x1b0 > > #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE1_MODE1 0x1b4 > > #define QSERDES_V4_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc > > #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE2_MODE1 0x1b8 > > > > FYI, the total size of serdes registers is 0x1c0. > > Yeah I will update it to 0x1c0 > > > > > <--snip--> > > > + ufs_mem_phy_lanes: lanes@1d87400 { > > > + reg = <0 0x01d87400 0 0x108>, > > > + <0 0x01d87600 0 0x1e0>, > > > + <0 0x01d87c00 0 0x1dc>, > > > > Same as above, see > > > > #define QPHY_V4_MULTI_LANE_CTRL1 0x1e0 > > > > FYI, the total size of PCS registers is 0x200 > > > > > + <0 0x01d87800 0 0x108>, > > > + <0 0x01d87a00 0 0x1e0>; > > > + #phy-cells = <0>; > > > + }; > > <--snip--> > > So I managed to fix it by configuring QPHY_SW_RESET in > qcom_qmp_phy_com_init() before invoking the configuration. That makes it > work for me. Will send patches shortly So, you are going to send some fixes to make sm8150 work. We also need the extended timeout for all platforms, yes? Who is going to send up the patch for the timeout? All of this should be -rc material since Can's change caused these issues to appear, and thus impact users, no?