linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nilesh Javali <njavali@marvell.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Manish Rangankar <mrangankar@marvell.com>,
	GR-QLogic-Storage-Upstream
	<GR-QLogic-Storage-Upstream@marvell.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_'
Date: Wed, 3 Mar 2021 16:12:33 +0000	[thread overview]
Message-ID: <DM6PR18MB30521DD343606F1AC95B2CD7AF989@DM6PR18MB3052.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210303144631.3175331-13-lee.jones@linaro.org>


> -----Original Message-----
> From: Lee Jones <lee.jones@linaro.org>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: lee.jones@linaro.org
> Cc: linux-kernel@vger.kernel.org; Nilesh Javali <njavali@marvell.com>;
> Manish Rangankar <mrangankar@marvell.com>; GR-QLogic-Storage-
> Upstream <GR-QLogic-Storage-Upstream@marvell.com>; James E.J.
> Bottomley <jejb@linux.ibm.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org
> Subject: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues -
> missing '-' and '_'
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/qla4xxx/ql4_os.c:631: warning: expecting prototype for
> qla4xxx_create chap_list(). Prototype was for qla4xxx_create_chap_list()
> instead
>  drivers/scsi/qla4xxx/ql4_os.c:9643: warning: expecting prototype for gets
> called if(). Prototype was for qla4xxx_pci_mmio_enabled() instead
> 
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: Manish Rangankar <mrangankar@marvell.com>
> Cc: GR-QLogic-Storage-Upstream@marvell.com
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 7bd9a4a04ad5d..597a64d91fe92 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -618,7 +618,7 @@ static umode_t qla4_attr_is_visible(int param_type,
> int param)
>  }
> 
>  /**
> - * qla4xxx_create chap_list - Create CHAP list from FLASH
> + * qla4xxx_create_chap_list - Create CHAP list from FLASH
>   * @ha: pointer to adapter structure
>   *
>   * Read flash and make a list of CHAP entries, during login when a CHAP
> entry
> @@ -9633,7 +9633,7 @@ qla4xxx_pci_error_detected(struct pci_dev *pdev,
> pci_channel_state_t state)
>  }
> 
>  /**
> - * qla4xxx_pci_mmio_enabled() gets called if
> + * qla4xxx_pci_mmio_enabled() - gets called if
>   * qla4xxx_pci_error_detected() returns PCI_ERS_RESULT_CAN_RECOVER
>   * and read/write to the device still works.
>   * @pdev: PCI device pointer
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <njavali@marvell.com>


  reply	other threads:[~2021-03-04  0:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 14:46 [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Lee Jones
2021-03-03 14:46 ` [PATCH 01/30] scsi: megaraid: megaraid_mm: Fix incorrect function name in header Lee Jones
2021-03-03 14:46 ` [PATCH 02/30] scsi: megaraid: megaraid_sas_base: Fix a bunch of misnamed functions in their headers Lee Jones
2021-03-03 14:46 ` [PATCH 03/30] scsi: fcoe: Fix function name fcoe_set_vport_symbolic_name() in description Lee Jones
2021-03-03 14:46 ` [PATCH 04/30] scsi: megaraid: megaraid_mbox: Fix function name megaraid_queue_command_lck() " Lee Jones
2021-03-03 14:46 ` [PATCH 05/30] scsi: fcoe: fcoe_ctlr: Fix a couple of incorrectly named functions Lee Jones
2021-03-03 14:46 ` [PATCH 06/30] scsi: aic94xx: aic94xx_hwi: Fix a couple of misnamed function names Lee Jones
2021-03-03 14:46 ` [PATCH 07/30] scsi: aacraid: aachba: Fix a few incorrectly named functions Lee Jones
2021-03-03 14:46 ` [PATCH 08/30] scsi: pm8001: pm8001_init: Provide function name and fix a misspelling Lee Jones
2021-03-04  9:51   ` Jinpu Wang
2021-03-03 14:46 ` [PATCH 09/30] scsi: aacraid: commctrl: Fix incorrect spelling of aac_send_raw_srb() Lee Jones
2021-03-03 14:46 ` [PATCH 10/30] scsi: bnx2fc: bnx2fc_hwi: Fix typo in bnx2fc_indicate_kcqe() Lee Jones
2021-03-03 14:46 ` [PATCH 11/30] scsi: pm8001: pm8001_sas: Provide function name 'pm8001_I_T_nexus_reset()' in header Lee Jones
2021-03-04  9:52   ` Jinpu Wang
2021-03-03 14:46 ` [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_' Lee Jones
2021-03-03 16:12   ` Nilesh Javali [this message]
2021-03-03 14:46 ` [PATCH 13/30] scsi: pm8001: pm8001_ctl: Fix incorrectly named functions in headers Lee Jones
2021-03-04  9:52   ` Jinpu Wang
2021-03-03 14:46 ` [PATCH 14/30] scsi: aic94xx: aic94xx_sds: Fix asd_erase_nv_sector()'s header Lee Jones
2021-03-03 14:46 ` [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores Lee Jones
2021-03-03 16:13   ` [EXT] " Nilesh Javali
2021-03-03 14:46 ` [PATCH 16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header Lee Jones
2021-03-03 14:46 ` [PATCH 17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues Lee Jones
2021-03-03 14:46 ` [PATCH 18/30] scsi: pm8001: pm8001_hwi: Fix some misnamed function descriptions Lee Jones
2021-03-04  9:53   ` Jinpu Wang
2021-03-03 14:46 ` [PATCH 19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue Lee Jones
2021-03-03 16:13   ` [EXT] " Nilesh Javali
2021-03-03 14:46 ` [PATCH 20/30] scsi: bnx2fc: bnx2fc_tgt: Fix misnaming of bnx2fc_free_session_resc() Lee Jones
2021-03-03 14:46 ` [PATCH 21/30] scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at least 13 years Lee Jones
2021-03-03 14:46 ` [PATCH 22/30] scsi: pm8001: pm80xx_hwi: Fix a bunch of doc-rotted function headers Lee Jones
2021-03-04  9:53   ` Jinpu Wang
2021-03-03 14:46 ` [PATCH 23/30] scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues Lee Jones
2021-03-03 16:13   ` [EXT] " Nilesh Javali
2021-03-03 14:46 ` [PATCH 24/30] scsi: aacraid: rx: Fix misspelling of _aac_rx_init() Lee Jones
2021-03-03 14:46 ` [PATCH 25/30] scsi: lpfc: lpfc_ct: Fix formatting and misspelling issues Lee Jones
2021-03-03 14:46 ` [PATCH 26/30] scsi: libfc: fc_lport: Fix some possible copy/paste issues Lee Jones
2021-03-03 14:46 ` [PATCH 27/30] scsi: lpfc: lpfc_hbadisc: Fix incorrect naming of __lpfc_update_fcf_record() Lee Jones
2021-03-03 14:46 ` [PATCH 28/30] scsi: mpt3sas: mpt3sas_base: Fix misspelling of _base_put_smid_default_atomic() Lee Jones
2021-03-03 14:46 ` [PATCH 29/30] scsi: lpfc: lpfc_nportdisc: Fix misspelling of lpfc_defer_acc_rsp() Lee Jones
2021-03-03 14:46 ` [PATCH 30/30] scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the heap Lee Jones
2021-03-16  2:15 ` [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Martin K. Petersen
2021-03-19  3:46 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR18MB30521DD343606F1AC95B2CD7AF989@DM6PR18MB3052.namprd18.prod.outlook.com \
    --to=njavali@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=jejb@linux.ibm.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mrangankar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).