Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Bean Huo <huobean@gmail.com>,
	"daejun7.park@samsung.com" <daejun7.park@samsung.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sang-yoon Oh <sangyoon.oh@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	Adel Choi <adel.choi@samsung.com>,
	BoRam Shin <boram.shin@samsung.com>
Subject: RE: [RFC PATCH v3 0/5] scsi: ufs: Add Host Performance Booster Support
Date: Mon, 29 Jun 2020 05:24:29 +0000
Message-ID: <SN6PR04MB464004B3DC7FB046A1E38F43FC6E0@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <948f573d136b39410f7d610e5019aafc9c04fe62.camel@gmail.com>

Hi Bean,
> 
> Hi Daejun
> 
> Seems you intentionally ignored to give you comments on my suggestion.
> let me provide the reason.
> 
> Before submitting your next version patch, please check your L2P
> mapping HPB reqeust submission logical algorithem. I have did
> performance comparison testing on 4KB, there are about 13% performance
> drop. Also the hit count is lower. I don't know if this is related to
> your current work queue scheduling, since you didn't add the timer for
> each HPB request.
In device control mode, the various decisions,
and specifically those that are causing repetitive evictions,
are made by the device.
Is this the issue that you are referring to? 

As for the driver, do you see any issue that is causing unnecessary latency? 

Thanks,
Avri 

  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p1>
2020-06-23  1:02 ` Daejun Park
     [not found]   ` <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p5>
2020-06-23  3:50     ` [RFC PATCH v3 1/5] scsi: ufs: Add UFS feature related parameter Daejun Park
     [not found]   ` <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p2>
2020-06-23  3:54     ` [RFC PATCH v3 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
     [not found]   ` <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p6>
2020-06-23  3:56     ` [RFC PATCH v3 3/5] scsi: ufs: Introduce HPB module Daejun Park
     [not found]   ` <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p7>
2020-06-23  4:03     ` [RFC PATCH v3 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-24  9:08       ` Avri Altman
     [not found]       ` <CGME20200623010201epcms2p11aebdf1fbc719b409968cba997507114@epcms2p3>
2020-06-25  0:18         ` Daejun Park
2020-06-29  6:15         ` [RFC PATCH v3 0/5] scsi: ufs: Add Host Performance Booster Support Daejun Park
2020-06-29 11:25           ` Bean Huo
2020-06-28 12:26   ` Bean Huo
2020-06-29  5:24     ` Avri Altman [this message]
2020-06-29 10:53       ` Bean Huo
2020-06-29 11:06         ` Avri Altman
2020-06-29 11:39           ` Bean Huo
2020-06-29  5:17   ` Avri Altman
2020-06-23  4:23 ` [RFC PATCH v3 5/5] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2020-06-30  1:05 ` [RFC PATCH v3 0/5] scsi: ufs: Add Host Performance Booster Support Daejun Park
2020-06-30  6:39   ` Avri Altman
2020-06-30 21:59     ` Bean Huo
2020-07-01  1:54     ` Alim Akhtar
2020-06-30 22:05   ` Bean Huo
2020-07-01  0:14 ` Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB464004B3DC7FB046A1E38F43FC6E0@SN6PR04MB4640.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=adel.choi@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sangyoon.oh@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=tomas.winkler@intel.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git