Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] ufs: fix a bug of wrong usage of test_and_set_bit
       [not found] <CGME20200727023402epcas2p2722148df6f3e24533f09381dc47aa906@epcas2p2.samsung.com>
@ 2020-07-27  2:25 ` Kiwoong Kim
  2020-07-27  6:24   ` Avri Altman
  0 siblings, 1 reply; 2+ messages in thread
From: Kiwoong Kim @ 2020-07-27  2:25 UTC (permalink / raw)
  To: linux-scsi, alim.akhtar, avri.altman, jejb, martin.petersen,
	beanhuo, asutoshd, cang, bvanassche, grant.jung, sc.suh,
	hy50.seo, sh425.lee
  Cc: Kiwoong Kim

Just a number should have been used, not a shifted value.

Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
 drivers/scsi/ufs/ufs-exynos.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
index a91656c..032bb50 100644
--- a/drivers/scsi/ufs/ufs-exynos.h
+++ b/drivers/scsi/ufs/ufs-exynos.h
@@ -216,7 +216,7 @@ struct exynos_ufs {
 
 	struct ufs_exynos_handle handle;
 	unsigned long dbg_flag;
-#define EXYNOS_UFS_DBG_DUMP_CXT			BIT(0)
+#define EXYNOS_UFS_DBG_DUMP_CXT			0
 };
 
 #define for_each_ufs_rx_lane(ufs, i) \
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v1] ufs: fix a bug of wrong usage of test_and_set_bit
  2020-07-27  2:25 ` [PATCH v1] ufs: fix a bug of wrong usage of test_and_set_bit Kiwoong Kim
@ 2020-07-27  6:24   ` Avri Altman
  0 siblings, 0 replies; 2+ messages in thread
From: Avri Altman @ 2020-07-27  6:24 UTC (permalink / raw)
  To: Kiwoong Kim, linux-scsi, alim.akhtar, jejb, martin.petersen,
	beanhuo, asutoshd, cang, bvanassche, grant.jung, sc.suh,
	hy50.seo, sh425.lee

 
> 
> Just a number should have been used, not a shifted value.
> 
> Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

Sorry for not catching this earlier.
Thanks,
Avri

> ---
>  drivers/scsi/ufs/ufs-exynos.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
> index a91656c..032bb50 100644
> --- a/drivers/scsi/ufs/ufs-exynos.h
> +++ b/drivers/scsi/ufs/ufs-exynos.h
> @@ -216,7 +216,7 @@ struct exynos_ufs {
> 
>         struct ufs_exynos_handle handle;
>         unsigned long dbg_flag;
> -#define EXYNOS_UFS_DBG_DUMP_CXT                        BIT(0)
> +#define EXYNOS_UFS_DBG_DUMP_CXT                        0
>  };
> 
>  #define for_each_ufs_rx_lane(ufs, i) \
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200727023402epcas2p2722148df6f3e24533f09381dc47aa906@epcas2p2.samsung.com>
2020-07-27  2:25 ` [PATCH v1] ufs: fix a bug of wrong usage of test_and_set_bit Kiwoong Kim
2020-07-27  6:24   ` Avri Altman

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git