From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sang-yoon Oh <sangyoon.oh@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Adel Choi <adel.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: RE: [PATCH v4 3/5] scsi: ufs: Introduce HPB module
Date: Tue, 30 Jun 2020 12:38:28 +0000 [thread overview]
Message-ID: <SN6PR04MB4640A27B0DCB321B165D59F0FC6F0@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1239183618.61593413882377.JavaMail.epsvc@epcpadp2>
> +static int ufshpb_get_dev_info(struct ufs_hba *hba,
> + struct ufshpb_dev_info *hpb_dev_info,
> + u8 *desc_buf)
> +{
> + int ret;
> + int version;
> + u8 hpb_mode;
Maybe before doing anything, first verify that all descriptors are in the proper size?
> +#define UFSHPB_WRITE_BUFFER_ID 0x02
Should be 0x01 for HPB1.0
Thanks,
Avri
next prev parent reply other threads:[~2020-06-30 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200629064323epcms2p787baba58a416fef7fdd3927f8da701da@epcms2p7>
2020-06-29 6:43 ` [PATCH v4 0/5] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20200629064323epcms2p787baba58a416fef7fdd3927f8da701da@epcms2p4>
2020-06-29 6:48 ` [PATCH v4 1/5] scsi: ufs: Add UFS feature related parameter Daejun Park
2020-06-29 6:55 ` [PATCH v4 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-06-30 12:38 ` Avri Altman [this message]
[not found] ` <CGME20200629064323epcms2p787baba58a416fef7fdd3927f8da701da@epcms2p2>
2020-06-29 6:58 ` [PATCH v4 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-30 12:42 ` Avri Altman
2020-06-29 7:31 ` [PATCH v4 5/5] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20200629064323epcms2p787baba58a416fef7fdd3927f8da701da@epcms2p3>
2020-06-29 6:50 ` [PATCH v4 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-07-01 0:07 ` [PATCH v4 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-07-01 0:11 ` [PATCH v4 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB4640A27B0DCB321B165D59F0FC6F0@SN6PR04MB4640.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=adel.choi@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sangyoon.oh@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=tomas.winkler@intel.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).