Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	"daejun7.park@samsung.com" <daejun7.park@samsung.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	'Sang-yoon Oh' <sangyoon.oh@samsung.com>,
	'Sung-Jun Park' <sungjun07.park@samsung.com>,
	'yongmyung lee' <ymhungry.lee@samsung.com>,
	'Jinyoung CHOI' <j-young.choi@samsung.com>,
	'Adel Choi' <adel.choi@samsung.com>,
	'BoRam Shin' <boram.shin@samsung.com>
Subject: RE: [PATCH v6 0/5] scsi: ufs: Add Host Performance Booster Support
Date: Wed, 22 Jul 2020 06:18:21 +0000
Message-ID: <SN6PR04MB4640A603AE3973E5738ED3DEFC790@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <yq1tuy0fag7.fsf@ca-mkp.ca.oracle.com>

> 
> Avri,
> 
> > Martin - Can we move forward with this one?
> 
>   CHECK   drivers/scsi/ufs/ufshcd-pltfrm.c
> drivers/scsi/ufs/ufsfeature.c:90:20: warning: symbol 'ufshpb_dev_type' was
> not declared. Should it be static?
> drivers/scsi/ufs/ufsfeature.c:104:17: warning: symbol 'ufsf_bus_type' was not
> declared. Should it be static?
>   CC [M]  drivers/scsi/ufs/ufsfeature.o
>   CC [M]  drivers/scsi/ufs/ufs_bsg.o
>   CC [M]  drivers/scsi/ufs/ufs-sysfs.o
> drivers/scsi/ufs/ufshpb.c:18:14: warning: symbol 'ufshpb_host_map_kbytes'
> was not declared. Should it be static?
> drivers/scsi/ufs/ufshpb.c:793:28: warning: mixing different enum types:
> drivers/scsi/ufs/ufshpb.c:793:28:    unsigned int enum HPB_RGN_STATE
> drivers/scsi/ufs/ufshpb.c:793:28:    unsigned int enum HPB_SRGN_STATE
>   CC [M]  drivers/scsi/ufs/ufshcd.o
> drivers/scsi/ufs/ufshpb.c:1026:31: warning: context imbalance in
> 'ufshpb_run_active_subregion_list' - different lock contexts for basic block

Martin - Thanks.

Daejun - please run Sparse as well, not just checkpatch to eliminate those warnings.

Thanks,
Avri

  reply index

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200713103423epcms2p8442ee7cc22395e4a4cedf224f95c45e8@epcms2p8>
2020-07-13 10:34 ` Daejun Park
     [not found]   ` <CGME20200713103423epcms2p8442ee7cc22395e4a4cedf224f95c45e8@epcms2p4>
2020-07-13 10:40     ` [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-07-22  6:41       ` Christoph Hellwig
2020-07-22 12:46         ` Martin K. Petersen
2020-07-22 15:06           ` Bart Van Assche
2020-07-13 10:53     ` [PATCH v6 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-07-15 18:34   ` [PATCH v6 0/5] scsi: ufs: Add Host Performance Booster Support Avi Shchislowski
2020-07-16  1:41     ` Bart Van Assche
2020-07-16 10:00       ` Avi Shchislowski
2020-07-16 16:21         ` Eric Biggers
2020-07-16 16:45         ` Alim Akhtar
2020-07-17 15:54           ` Avi Shchislowski
2020-08-10 15:38         ` Greg KH
2020-07-16  8:13     ` Bean Huo
2020-07-16  8:14     ` Bean Huo
2020-07-16  1:05   ` Alim Akhtar
2020-07-17  5:24     ` Avri Altman
2020-07-19  6:35       ` Avri Altman
2020-07-21 18:15         ` Alim Akhtar
2020-07-22  4:20         ` Martin K. Petersen
2020-07-22  6:18           ` Avri Altman [this message]
2020-07-22  6:39   ` Christoph Hellwig
2020-07-22 13:27     ` Martin K. Petersen
2020-07-22 14:34       ` Bart Van Assche
2020-07-27  9:33     ` Pavel Machek
     [not found]   ` <CGME20200713103423epcms2p8442ee7cc22395e4a4cedf224f95c45e8@epcms2p3>
2020-07-13 10:38     ` [PATCH v6 1/5] scsi: ufs: Add UFS feature related parameter Daejun Park
2020-07-13 12:13       ` Can Guo
2020-07-13 10:58     ` [PATCH v6 5/5] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2020-07-27  6:18     ` [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-08-04 18:43       ` Bart Van Assche
     [not found]   ` <CGME20200713103423epcms2p8442ee7cc22395e4a4cedf224f95c45e8@epcms2p1>
2020-07-13 10:50     ` [PATCH v6 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-08-04 23:33     ` Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB4640A603AE3973E5738ED3DEFC790@SN6PR04MB4640.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=adel.choi@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sangyoon.oh@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=tomas.winkler@intel.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git