From: <Don.Brace@microchip.com>
To: <hare@suse.de>, <martin.petersen@oracle.com>
Cc: <hch@lst.de>, <james.bottomley@hansenpartnership.com>,
<john.garry@huawei.com>, <ming.lei@redhat.com>,
<bvanassche@acm.org>, <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH RFC v3 00/41] scsi: enable reserved commands for LLDDs
Date: Fri, 5 Jun 2020 15:32:25 +0000 [thread overview]
Message-ID: <SN6PR11MB2848512EB578D01F981F8705E1860@SN6PR11MB2848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200430131904.5847-1-hare@suse.de>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
git://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git reserved-tags.v3
As usual, comments and reviews are welcome.
I cloned your tree and ran some tests using hpsa.
I used 3 SATA HBA disks, 3 SAS HBA disks, 2 LOGICAL VOLUMES using HDDs, and 2 LOGICAL VOLUMES using SDDs for ioaccel path.
I have an IO stress test that does mkfs, mount/umount, fio, and fsck to the above volumes while doing sg_reset opeations in parallel.
The stress test has survived 2 full days of testing.
However, my insmod/rmmod test causes a kernel panic.
Not sure why yet. I had re-cloned yesterday an d the panic is still there.
Earlier kernel versions do not panic on rmmod.
--
2.16.4
[-- Attachment #2: reserved-tags.v3_hpsa_rmmod_stack_trace --]
[-- Type: application/octet-stream, Size: 7554 bytes --]
[ 465.418031] NMI watchdog: Watchdog detected hard LOCKUP on cpu 50
[ 465.418032] Modules linked in: xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nft_counter nf_nat_tftp nft_objref nf_conntrack_tftp tun bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack rfkill nf_defrag_ipv6 nf_defrag_ipv4 ip6_tables nft_compat ip_set nf_tables nfnetlink sunrpc vfat fat intel_rapl_msr intel_rapl_common sb_edac x86_pkg_temp_thermal intel_powerclamp ipmi_ssif coretemp kvm_intel kvm iTCO_wdt iTCO_vendor_support irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel intel_cstate intel_uncore ipmi_si intel_rapl_perf ioatdma joydev ses pcspkr lpc_ich hpilo i2c_i801 hpwdt enclosure ipmi_devintf dca ipmi_msghandler acpi_tad acpi_power_meter ip_tables xfs libcrc32c mgag200 drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_vram_helper drm_ttm_helper ttm sd_mod t10_pi sg ahci libahci drm uas libata usb_storage tg3 crc32c_intel i2c_algo_bit hpsa(-)
[ 465.418047] scsi_transport_sas wmi dm_mirror dm_region_hash dm_log dm_mod
[ 465.418049] CPU: 50 PID: 3455 Comm: rmmod Not tainted 5.7.0-rc1+ #1
[ 465.418049] Hardware name: HP ProLiant ML350 Gen9/ProLiant ML350 Gen9, BIOS P92 10/17/2018
[ 465.418050] RIP: 0010:native_queued_spin_lock_slowpath+0x5b/0x1c0
[ 465.418050] Code: 6d f0 0f ba 2f 08 0f 92 c0 0f b6 c0 c1 e0 08 89 c2 8b 07 30 e4 09 d0 a9 00 01 ff ff 75 47 85 c0 74 0e 8b 07 84 c0 74 08 f3 90 <8b> 07 84 c0 75 f8 b8 01 00 00 00 66 89 07 c3 8b 37 81 fe 00 01 00
[ 465.418051] RSP: 0018:ffffb0dbc275bd28 EFLAGS: 00000002
[ 465.418052] RAX: 0000000000000101 RBX: 0000000000000246 RCX: 0000000000000000
[ 465.418052] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8c8326bfd830
[ 465.418052] RBP: 0000000000000000 R08: 00000000000003be R09: 0000000000000000
[ 465.418053] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8c83269bd820
[ 465.418053] R13: ffffffffc0358150 R14: ffff8c8324527800 R15: 0000000000000000
[ 465.418053] FS: 00007f440c326740(0000) GS:ffff8c8537b80000(0000) knlGS:0000000000000000
[ 465.418054] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 465.418054] CR2: 0000557a65edee08 CR3: 00000003ec2a6002 CR4: 00000000001606e0
[ 465.418054] Call Trace:
[ 465.418054] _raw_spin_lock_irqsave+0x22/0x30
[ 465.418055] scsi_device_dev_release_usercontext+0x46/0x2b0
[ 465.418055] ? __cancel_work_timer+0x103/0x190
[ 465.418055] execute_in_process_context+0x21/0x60
[ 465.418055] device_release+0x27/0x80
[ 465.418056] kobject_put+0xa6/0x1b0
[ 465.418056] scsi_forget_host+0x73/0x9d
[ 465.418056] scsi_remove_host+0x72/0x110
[ 465.418056] hpsa_remove_one+0xad/0x1a0 [hpsa]
[ 465.418057] pci_device_remove+0x3b/0xc0
[ 465.418057] device_release_driver_internal+0xe5/0x1c0
[ 465.418057] driver_detach+0x46/0x87
[ 465.418057] bus_remove_driver+0x77/0xcc
[ 465.418058] pci_unregister_driver+0x2a/0xa0
[ 465.418058] hpsa_cleanup+0xc/0x4a7 [hpsa]
[ 465.418058] __x64_sys_delete_module+0x139/0x280
[ 465.418058] do_syscall_64+0x55/0x1b0
[ 465.418059] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 465.418059] RIP: 0033:0x7f440b3197db
[ 465.418060] Code: 73 01 c3 48 8b 0d ad f6 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 7d f6 2b 00 f7 d8 64 89 01 48
[ 465.418060] RSP: 002b:00007ffe6c6d4fc8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
[ 465.418061] RAX: ffffffffffffffda RBX: 0000557a65ed47a0 RCX: 00007f440b3197db
[ 465.418061] RDX: 000000000000000a RSI: 0000000000000800 RDI: 0000557a65ed4808
[ 465.418061] RBP: 0000000000000000 R08: 00007ffe6c6d3f41 R09: 0000000000000000
[ 465.418061] R10: 00007f440b38b8e0 R11: 0000000000000206 R12: 00007ffe6c6d51f0
[ 465.418062] R13: 00007ffe6c6d5c58 R14: 0000557a65ed42a0 R15: 0000557a65ed47a0
[ 465.418062] Kernel panic - not syncing: Hard LOCKUP
[ 465.418062] CPU: 50 PID: 3455 Comm: rmmod Not tainted 5.7.0-rc1+ #1
[ 465.418063] Hardware name: HP ProLiant ML350 Gen9/ProLiant ML350 Gen9, BIOS P92 10/17/2018
[ 465.418063] Call Trace:
[ 465.418063] <NMI>
[ 465.418063] dump_stack+0x50/0x70
[ 465.418064] panic+0xfb/0x2d7
[ 465.418064] nmi_panic.cold.10+0xc/0xc
[ 465.418064] watchdog_overflow_callback.cold.7+0x5c/0x70
[ 465.418064] __perf_event_overflow+0x52/0xf0
[ 465.418065] handle_pmi_common+0x1ca/0x290
[ 465.418065] ? set_pte_vaddr_p4d+0x4a/0x60
[ 465.418065] ? __native_set_fixmap+0x24/0x30
[ 465.418065] ? ghes_copy_tofrom_phys+0x8f/0x110
[ 465.418066] ? __ghes_peek_estatus.isra.10+0x49/0xa0
[ 465.418066] intel_pmu_handle_irq+0xc9/0x1c0
[ 465.418066] perf_event_nmi_handler+0x2d/0x50
[ 465.418066] nmi_handle+0x61/0x160
[ 465.418067] default_do_nmi+0x4e/0x100
[ 465.418067] do_nmi+0x159/0x1c0
[ 465.418067] end_repeat_nmi+0x16/0x50
[ 465.418068] RIP: 0010:native_queued_spin_lock_slowpath+0x5b/0x1c0
[ 465.418068] Code: 6d f0 0f ba 2f 08 0f 92 c0 0f b6 c0 c1 e0 08 89 c2 8b 07 30 e4 09 d0 a9 00 01 ff ff 75 47 85 c0 74 0e 8b 07 84 c0 74 08 f3 90 <8b> 07 84 c0 75 f8 b8 01 00 00 00 66 89 07 c3 8b 37 81 fe 00 01 00
[ 465.418069] RSP: 0018:ffffb0dbc275bd28 EFLAGS: 00000002
[ 465.418069] RAX: 0000000000000101 RBX: 0000000000000246 RCX: 0000000000000000
[ 465.418070] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8c8326bfd830
[ 465.418070] RBP: 0000000000000000 R08: 00000000000003be R09: 0000000000000000
[ 465.418071] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8c83269bd820
[ 465.418071] R13: ffffffffc0358150 R14: ffff8c8324527800 R15: 0000000000000000
[ 465.418071] ? native_queued_spin_lock_slowpath+0x5b/0x1c0
[ 465.418071] ? native_queued_spin_lock_slowpath+0x5b/0x1c0
[ 465.418072] </NMI>
[ 465.418072] _raw_spin_lock_irqsave+0x22/0x30
[ 465.418072] scsi_device_dev_release_usercontext+0x46/0x2b0
[ 465.418072] ? __cancel_work_timer+0x103/0x190
[ 465.418073] execute_in_process_context+0x21/0x60
[ 465.418073] device_release+0x27/0x80
[ 465.418073] kobject_put+0xa6/0x1b0
[ 465.418073] scsi_forget_host+0x73/0x9d
[ 465.418074] scsi_remove_host+0x72/0x110
[ 465.418074] hpsa_remove_one+0xad/0x1a0 [hpsa]
[ 465.418074] pci_device_remove+0x3b/0xc0
[ 465.418074] device_release_driver_internal+0xe5/0x1c0
[ 465.418075] driver_detach+0x46/0x87
[ 465.418075] bus_remove_driver+0x77/0xcc
[ 465.418075] pci_unregister_driver+0x2a/0xa0
[ 465.418075] hpsa_cleanup+0xc/0x4a7 [hpsa]
[ 465.418076] __x64_sys_delete_module+0x139/0x280
[ 465.418076] do_syscall_64+0x55/0x1b0
[ 465.418076] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 465.418076] RIP: 0033:0x7f440b3197db
[ 465.418077] Code: 73 01 c3 48 8b 0d ad f6 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 7d f6 2b 00 f7 d8 64 89 01 48
[ 465.418077] RSP: 002b:00007ffe6c6d4fc8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
[ 465.418078] RAX: ffffffffffffffda RBX: 0000557a65ed47a0 RCX: 00007f440b3197db
[ 465.418078] RDX: 000000000000000a RSI: 0000000000000800 RDI: 0000557a65ed4808
[ 465.418078] RBP: 0000000000000000 R08: 00007ffe6c6d3f41 R09: 0000000000000000
[ 465.418079] R10: 00007f440b38b8e0 R11: 0000000000000206 R12: 00007ffe6c6d51f0
[ 465.418079] R13: 00007ffe6c6d5c58 R14: 0000557a65ed42a0 R15: 0000557a65ed47a0
[ 465.521499] Kernel Offset: 0x18800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
next prev parent reply other threads:[~2020-06-05 15:32 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 13:18 [PATCH RFC v3 00/41] scsi: enable reserved commands for LLDDs Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 01/41] scsi: add 'nr_reserved_cmds' field to the SCSI host template Hannes Reinecke
2020-04-30 14:15 ` John Garry
2020-04-30 14:48 ` Hannes Reinecke
2020-05-01 4:36 ` Bart Van Assche
2020-05-01 17:48 ` Christoph Hellwig
2020-05-04 6:13 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 02/41] scsi: add scsi_{get,put}_reserved_cmd() Hannes Reinecke
2020-04-30 17:11 ` Douglas Gilbert
2020-05-01 15:42 ` Hannes Reinecke
2020-05-01 4:35 ` Bart Van Assche
2020-05-01 12:01 ` John Garry
2020-05-02 12:24 ` Hannes Reinecke
2020-05-01 17:39 ` Christoph Hellwig
2020-05-02 8:45 ` Hannes Reinecke
2020-05-02 8:48 ` Christoph Hellwig
2020-04-30 13:18 ` [PATCH RFC v3 03/41] scsi: Implement scsi_cmd_is_reserved() Hannes Reinecke
2020-05-01 4:38 ` Bart Van Assche
2020-05-01 17:43 ` Christoph Hellwig
2020-05-02 8:46 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 04/41] csiostor: use reserved command for LUN reset Hannes Reinecke
2020-04-30 15:15 ` Ming Lei
2020-05-01 13:01 ` Hannes Reinecke
2020-05-01 15:01 ` Ming Lei
2020-05-01 17:45 ` Christoph Hellwig
2020-05-02 3:11 ` Ming Lei
2020-05-04 6:43 ` Hannes Reinecke
2020-05-02 8:49 ` Hannes Reinecke
2020-05-02 14:29 ` Ming Lei
2020-05-04 6:55 ` Hannes Reinecke
2020-05-04 8:47 ` Ming Lei
2020-05-04 10:24 ` Hannes Reinecke
2020-05-04 10:49 ` Ming Lei
2020-05-02 16:10 ` Bart Van Assche
2020-05-04 7:02 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 05/41] scsi: add scsi_cmd_from_priv() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 06/41] virtio_scsi: use reserved commands for TMF Hannes Reinecke
2020-04-30 15:17 ` Ming Lei
2020-05-04 9:25 ` Ming Lei
2020-05-04 10:21 ` Hannes Reinecke
2020-05-04 10:35 ` Ming Lei
2020-04-30 13:18 ` [PATCH RFC v3 07/41] fnic: use reserved commands Hannes Reinecke
2020-04-30 15:24 ` Ming Lei
2020-04-30 13:18 ` [PATCH RFC v3 08/41] fnic: use scsi_host_busy_iter() to traverse commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 09/41] scsi: use real inquiry data when initialising devices Hannes Reinecke
2020-05-01 17:49 ` Christoph Hellwig
2020-05-04 6:26 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 10/41] scsi: make host device a first-class citizen Hannes Reinecke
2020-05-01 4:49 ` Bart Van Assche
2020-04-30 13:18 ` [PATCH RFC v3 11/41] hpsa: move hpsa_hba_inquiry after scsi_add_host() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 12/41] hpsa: use reserved commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 13/41] hpsa: use scsi_host_busy_iter() to traverse outstanding commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 14/41] hpsa: drop refcount field from CommandList Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 15/41] aacraid: use private commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 16/41] aacraid: use scsi_host_busy_iter() to traverse commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 17/41] megaraid_sas: kill this_id and init_id Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 18/41] megaraid_sas: use shost_priv() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 19/41] megaraid_sas: avoid using megaraid_lookup_instance() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 20/41] megaraid_sas: separate out megasas_set_max_sectors() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 21/41] megaraid_sas: megaraid_sas: reshuffle SCSI host allocation Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 22/41] block: implement persistent commands Hannes Reinecke
2020-05-01 4:59 ` Bart Van Assche
2020-05-02 12:11 ` Hannes Reinecke
2020-05-02 16:22 ` Bart Van Assche
2020-05-01 8:33 ` Ming Lei
2020-05-02 12:22 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 23/41] scsi: add a 'persistent' argument to scsi_get_reserved_cmd() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 24/41] megaraid_sas: separate out megasas_prepare_aen() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 25/41] megaraid_sas: use reserved commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 26/41] megaraid_sas_fusion: rearrange mfi and mpt frame pools Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 27/41] megaraid_sas_fusion: sanitize command lookup Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 28/41] megaraid_sas: use scsi_host_busy_iter to traverse outstanding commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 29/41] snic: use reserved commands Hannes Reinecke
2020-05-02 3:19 ` Ming Lei
2020-05-04 6:45 ` Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 30/41] snic: use tagset iter for traversing commands Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 31/41] mv_sas: kill mvsas_debug_issue_ssp_tmf() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 32/41] pm8001: kill pm8001_issue_ssp_tmf() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 33/41] pm8001: kill 'dev' argument from pm8001_exec_internal_task_abort() Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 34/41] pm8001: use libsas-provided domain devices for SATA Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 35/41] libsas: add SCSI target pointer to struct domain_device Hannes Reinecke
2020-04-30 13:18 ` [PATCH RFC v3 36/41] scsi: libsas,hisi_sas,mvsas,pm8001: Allocate Scsi_cmd for slow task Hannes Reinecke
2020-05-01 10:53 ` John Garry
2020-04-30 13:19 ` [PATCH RFC v3 37/41] libsas: add tag to struct sas_task Hannes Reinecke
2020-05-01 10:26 ` John Garry
2020-05-02 12:42 ` Hannes Reinecke
2020-05-04 7:49 ` John Garry
2020-05-04 8:00 ` Hannes Reinecke
2020-05-05 8:38 ` John Garry
2020-04-30 13:19 ` [PATCH RFC v3 38/41] scsi: hisi_sas: Use libsas slow task SCSI command Hannes Reinecke
2020-04-30 13:19 ` [PATCH RFC v3 39/41] hisi_sas: use task tag to reference the slot Hannes Reinecke
2020-04-30 13:19 ` [PATCH RFC v3 40/41] mv_sas: use reserved tags and drop private tag allocation Hannes Reinecke
2020-04-30 13:19 ` [PATCH RFC v3 41/41] pm8001: use block-layer tags for ccb allocation Hannes Reinecke
2020-05-01 10:47 ` John Garry
2020-05-01 12:01 ` [PATCH RFC v3 00/41] scsi: enable reserved commands for LLDDs John Garry
2020-05-02 12:23 ` Hannes Reinecke
2020-05-01 17:46 ` Christoph Hellwig
2020-05-04 6:16 ` Hannes Reinecke
2020-06-05 15:32 ` Don.Brace [this message]
2020-06-05 16:50 ` Hannes Reinecke
2020-06-05 17:01 ` Don.Brace
2020-06-08 21:56 ` Don.Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2848512EB578D01F981F8705E1860@SN6PR11MB2848.namprd11.prod.outlook.com \
--to=don.brace@microchip.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).