From: <Viswas.G@microchip.com>
To: <martin.petersen@oracle.com>
Cc: <Viswas.G@microchip.com.com>, <linux-scsi@vger.kernel.org>,
<Vasanthalakshmi.Tharmarajan@microchip.com>,
<Deepak.Ukey@microchip.com>, <yuuzheng@google.com>,
<auradkar@google.com>, <vishakhavc@google.com>,
<bjashnani@google.com>, <radha@google.com>,
<akshatzen@google.com>
Subject: RE: [PATCH v8 1/2] pm80xx : Support for get phy profile functionality.
Date: Wed, 9 Sep 2020 10:15:36 +0000 [thread overview]
Message-ID: <SN6PR11MB3488F126461CC2C8764A3F329D260@SN6PR11MB3488.namprd11.prod.outlook.com> (raw)
In-Reply-To: <yq1a6y7ek7u.fsf@ca-mkp.ca.oracle.com>
Hi Martin,
This is not exposed to userland anymore. We have submitted an IOCTL support in driver to
expose these information and later dropped it since similar functionality can be achieved
through libsas sysfs entries. Controller exposes the phy error counter and status
information pages through IOMB. We retained this patch in driver thinking that it might be
useful if we want to query these information through driver sysfs or by some other means.
We are okay to drop this. Please suggest.
Regards,
Viswas G
> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@oracle.com>
> Sent: Thursday, September 3, 2020 6:48 AM
> To: Viswas G - I30667 <Viswas.G@microchip.com>
> Cc: martin.petersen@oracle.com; Viswas.G@microchip.com.com; linux-
> scsi@vger.kernel.org; Vasanthalakshmi Tharmarajan - I30664
> <Vasanthalakshmi.Tharmarajan@microchip.com>; Deepak Ukey - I31172
> <Deepak.Ukey@microchip.com>; yuuzheng@google.com;
> auradkar@google.com; vishakhavc@google.com; bjashnani@google.com;
> radha@google.com; akshatzen@google.com
> Subject: Re: [PATCH v8 1/2] pm80xx : Support for get phy profile
> functionality.
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
>
> Hi Viswas!
>
> >> Where are these parameters made visible?
> >>
> >> Also, why not make the phy_errcnt members __le32 instead of using
> >> __force?
> >
> > This was added to avoid sparse compiler warnings reported.
>
> Yes, but those warnings are indicative that your struct definitions are
> problematic. I suggest you have one struct with __le32 members which you
> use when querying the values from the hardware. And then another struct
> that's host-endian. Which goes back to my first question: Where are these
> phy parameters actually used and/or exposed to userland?
>
> --
> Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-09-09 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 18:51 [PATCH v8 0/2] pm80xx : Updates for the driver version 0.1.39 Viswas G
2020-08-20 18:51 ` [PATCH v8 1/2] pm80xx : Support for get phy profile functionality Viswas G
2020-09-02 1:19 ` Martin K. Petersen
2020-09-02 6:35 ` Viswas.G
2020-09-03 1:17 ` Martin K. Petersen
2020-09-09 10:15 ` Viswas.G [this message]
2020-08-20 18:51 ` [PATCH v8 2/2] pm80xx : Staggered spin up support Viswas G
2020-09-02 1:20 ` Martin K. Petersen
2020-09-02 6:38 ` Viswas.G
2020-09-11 5:41 ` Viswas.G
2020-09-11 7:30 ` John Garry
[not found] ` <SN6PR11MB348877970A45BA993C95D14D9D5B0@SN6PR11MB3488.namprd11.prod.outlook.com>
2020-09-02 14:05 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3488F126461CC2C8764A3F329D260@SN6PR11MB3488.namprd11.prod.outlook.com \
--to=viswas.g@microchip.com \
--cc=Deepak.Ukey@microchip.com \
--cc=Vasanthalakshmi.Tharmarajan@microchip.com \
--cc=Viswas.G@microchip.com.com \
--cc=akshatzen@google.com \
--cc=auradkar@google.com \
--cc=bjashnani@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=radha@google.com \
--cc=vishakhavc@google.com \
--cc=yuuzheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).