From: Konstantin Shelekhin <k.shelekhin@yadro.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>, <linux@yadro.com>,
<linux-scsi@vger.kernel.org>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH 1/2] target: Add the DUMMY flag to rd_mcp
Date: Mon, 22 Mar 2021 21:57:51 +0300 [thread overview]
Message-ID: <YFjor951E++2VcaR@yadro.com> (raw)
In-Reply-To: <83e2f363-978f-eba2-cff1-ff007cc139ca@oracle.com>
On Mon, Mar 22, 2021 at 12:06:36PM -0500, Mike Christie wrote:
> > +static u32 rd_get_device_type(struct se_device *dev)
> > +{
> > + if (RD_DEV(dev)->rd_flags & RDF_DUMMY)
> > + return 0x3f; /* Unknown device type, not connected */
> > + else
> > + return TYPE_DISK;
>
> Maybe have this call sbc_get_device_type here so it matches the other drivers
> and how this driver calls into lio core for other operations/fields like
> parse_cdb or the attrs.
Yeah, good point, I'll fix and send the next round. Are you okay with
the whole idea though?
next prev parent reply other threads:[~2021-03-22 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:42 [PATCH 0/2] target: Introduce dummy devices Konstantin Shelekhin
2021-03-18 9:42 ` [PATCH 1/2] target: Add the DUMMY flag to rd_mcp Konstantin Shelekhin
2021-03-22 17:06 ` Mike Christie
2021-03-22 18:57 ` Konstantin Shelekhin [this message]
2021-03-18 9:42 ` [PATCH 2/2] target: Make the virtual LUN 0 device dummy Konstantin Shelekhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFjor951E++2VcaR@yadro.com \
--to=k.shelekhin@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).