From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window
Date: Fri, 3 Sep 2021 08:57:07 +0100 [thread overview]
Message-ID: <YTHVUxc5xZzr77er@infradead.org> (raw)
In-Reply-To: <YTGkLhfYWcvj4YRn@infradead.org>
On Fri, Sep 03, 2021 at 05:27:26AM +0100, Christoph Hellwig wrote:
> On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote:
> > >
> > > Just checking that was fine, and I notice how *many* places do that.
> > >
> > > Should the blk_execute_rq() function even take that "struct gendisk
> > > *bd_disk" argument at all?
>
> No, it shouldn't. rq->rq_disk should go away and use rq->q->disk
> instead. This has been on my TODO list, but didn't make the cut for
> this merge window.
Here is a quick draft of that:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-remove-rq_disk
next prev parent reply other threads:[~2021-09-03 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 16:50 [GIT PULL] first round of SCSI updates for the 5.14+ merge window James Bottomley
2021-09-02 22:38 ` Linus Torvalds
2021-09-02 22:46 ` Jens Axboe
2021-09-02 23:23 ` James Bottomley
2021-09-02 23:32 ` Jens Axboe
2021-09-03 4:27 ` Christoph Hellwig
2021-09-03 7:57 ` Christoph Hellwig [this message]
2021-09-02 22:42 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTHVUxc5xZzr77er@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).