archive mirror
 help / color / mirror / Atom feed
* [Regression][Stable] sd use scsi_mode_sense with invalid param
@ 2021-11-26 21:11 Tom Yan
  2021-11-26 21:21 ` Tom Yan
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Yan @ 2021-11-26 21:11 UTC (permalink / raw)
  To: linux-scsi, damien.lemoal, martin.petersen, sashal


So with 17b49bcbf8351d3dbe57204468ac34f033ed60bc (upstream),
scsi_mode_sense now returns -EINVAL if len < 8, yet in sd, the first mode
sense attempted by sd_read_cache_type() is done with (first_)len being
4, which results in the failure of the attempt.

Since the commit is merged into stable, my SATA drive (that has
volatile write cache) is assumed to be a "write through" drive after I
upgraded from 5.15.4 to 5.15.5, as libata sets use_10_for_ms to 1.

Since sd does not (get to) determine which mode sense command to use,
should scsi_mode_sense at least accept a special value 0 (which
first_len would be set to), which is use to refers to the minimum len
to use for mode sense 6 and 10 respectively (i.e. 4 or 8)?


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-27 12:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 21:11 [Regression][Stable] sd use scsi_mode_sense with invalid param Tom Yan
2021-11-26 21:21 ` Tom Yan
2021-11-26 21:33   ` Tom Yan
2021-11-27  1:15     ` Damien Le Moal
2021-11-27 11:55       ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).