From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Asutosh Das <asutoshd@codeaurora.org>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Can Guo <cang@codeaurora.org>
Subject: Re: [PATCH] scsi: ufs: add a quirk to disable FUA support
Date: Wed, 1 Jun 2022 10:06:23 -0700 [thread overview]
Message-ID: <Ypecj07egjAZTZbK@google.com> (raw)
In-Reply-To: <3e13bf8f-060c-fc81-4405-e7d5820518cc@acm.org>
On 06/01, Bart Van Assche wrote:
> On 5/31/22 22:24, Adrian Hunter wrote:
> > On 31/05/22 23:10, Jaegeuk Kim wrote:
> > > + /*
> > > + * This quirk disables FUA support.
> > > + */
> > > + UFSHCD_QUIRK_BROKEN_FUA = 1 << 17,
> >
> > Wouldn't it be more appropriate to make it a UFS_DEVICE_QUIRK_
> > since it presumably depends on the UFS device not the host controller?
> >
> > Also, as already commented by others, there needs to be a user of
> > the quirk
>
> Another possibility is to use the generic SCSI blacklist mechanism. See also
> the scsi_static_device_list array. See also /proc/scsi/device_info. From
> scsi_devinfo.c:
>
> /*
> * proc_scsi_dev_info_write - allow additions to scsi_dev_info_list via
> * /proc.
> *
> * Description: Adds a black/white list entry for vendor and model with
> * an integer value of flag to the scsi device info list.
> * To use, echo "vendor:model:flag" > /proc/scsi/device_info
> */
Good to know. Thank you, Bart.
>
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2022-06-01 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 20:10 [PATCH] scsi: ufs: add a quirk to disable FUA support Jaegeuk Kim
2022-05-31 20:34 ` Eric Biggers
2022-05-31 20:53 ` Jaegeuk Kim
2022-05-31 21:25 ` Eric Biggers
2022-06-07 16:45 ` Asutosh Das
2022-06-01 5:24 ` Adrian Hunter
2022-06-01 11:59 ` Bart Van Assche
2022-06-01 17:06 ` Jaegeuk Kim [this message]
2022-06-01 17:05 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ypecj07egjAZTZbK@google.com \
--to=jaegeuk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).