Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Hou Pu <houpu@bytedance.com>,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: mchristi@redhat.com
Subject: Re: [PATCH v4 0/2] iscsi-target: fix login error when receiving is too fast
Date: Sat, 25 Jul 2020 21:58:55 -0500
Message-ID: <a78662d5-0bb4-8b27-125e-b4c2176b70c6@oracle.com> (raw)
In-Reply-To: <20200716100212.4237-1-houpu@bytedance.com>

On 7/16/20 5:02 AM, Hou Pu wrote:
> Hi,
> We encountered "iSCSI Login negotiation failed" several times.
> After enable debug log in iscsi_target_nego.c of iSCSI target.
> Error shows:
>   "Got LOGIN_FLAGS_READ_ACTIVE=1, conn: xxxxxxxxxx >>>>"
> 
> Patch 1 is trying to fix this problem. Please see comment in patch 1
> for details.
> 
> Sorry for delay of v4. Version 3 of this patchset could be found here[1].
> 
> Changes from v4:
> * In iscsi_target_do_login_rx(), call cancel_delayed_work() if it is final
>   login pdu. Also call cancel_delayed_work() if current negotiation is failed.
>   This is advised by Mike Christie. See below[1] for more details.
> 
> Changes from v3:
> * Fix style problem found by checkpatch.pl.
> 
Ah sorry, I thought I replied a little later about my concerns being overly paranoid and your patch being ok. I don't see it on the list so not sure what happened.

If you are still not liking the cancel call, I'm ok with v3. Add my reviewed by to either version you prefer.

Reviewed-by: Mike Christie <michael.christie@oracle.com>

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 10:02 Hou Pu
2020-07-16 10:02 ` [PATCH v4 1/2] " Hou Pu
2020-07-16 10:02 ` [PATCH v4 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Hou Pu
2020-07-26  2:58 ` Mike Christie [this message]
2020-07-28  3:16   ` [PATCH v4 0/2] iscsi-target: fix login error when receiving is too fast Hou Pu
2020-07-29  4:10 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a78662d5-0bb4-8b27-125e-b4c2176b70c6@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=houpu@bytedance.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mchristi@redhat.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git