From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDC8C433E0 for ; Tue, 26 May 2020 16:48:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4839E207D8 for ; Tue, 26 May 2020 16:48:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dCxwuhqp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731519AbgEZQsR (ORCPT ); Tue, 26 May 2020 12:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731501AbgEZQsQ (ORCPT ); Tue, 26 May 2020 12:48:16 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749AFC03E97C for ; Tue, 26 May 2020 09:48:15 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id d7so22790036ioq.5 for ; Tue, 26 May 2020 09:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CDy85Gj7MYd1kNtILJcUzn7KVIhIM0XshsVeAc/i0tA=; b=dCxwuhqpPbwbXsS8D4GR15Oi/vkWvJ2t6JE5jqhDuEYRBCxiAwo9cWnqARqt/pZ9N3 vSDlZ8wDeZydMMsvQgllY5SFL21AkwmUO/yVMpJRwkWuLZ+okFm2plV7st5ZUHxgg7+n nw9y2DMW7Y1odFWc8D0ovkNrkmBQTlf+wVi0icllMuisiL6LQjhD1eU0HTahi0uvVson 7H1igoRa7sC3VzH0k6kw37/8QsEYXM6RYbG1TkZAtikaoCp3wlyHVEwAfTjAFYYV3q4L NgflHMgnD8hmupC7gXChsbUVMFzyhgq3aBSV9WdpBp5mfIm6+JpoU8GgF7qXRXSqT3gV qZIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CDy85Gj7MYd1kNtILJcUzn7KVIhIM0XshsVeAc/i0tA=; b=hhm8jY1y4BjWk8Q9TsoebhZt58P5yHxVcmhHw6WwfFOMD0l5mBGSaKr43KC22k3GL7 zQo24gW+vDGcS4jflcwaFIAiCMZHY9KAIlDXPlBz0Ex26qU0ihoRadz4xRy7BCkRV/qr mBtjfzmR8jWUfcE8ptPL8uY8IQ6tMMm5BJ9beApqP/9ZXy6r6BzgV+yKECC7YgCUeL3F stOoZJg7ESW6+8y6hNFgVbucAoiHAgOEUKJ+OXmYkd8L+A9O75pZvHeLD65d8G07rkOL xzaIPnHLZKPMJyl6cbM0HDu48UXUXXj3chkd0gp1IjowGzi2i8vEBGUoXIIiAFXQPUPk CQEw== X-Gm-Message-State: AOAM533fNFIogZ3hiKRfOeN9rOXe/k2RTeD7N8Yl4lWM9CYiHSL1hBay tNZq//NlANYM7XeQRRsQ6I/DOw== X-Google-Smtp-Source: ABdhPJwt8EDbE+Md3qNwECgPyEhh34GzLnn6Kwx5Q+Egs2R3PU4UAkkaFOOCDwhKuojJpS4rMr4mTQ== X-Received: by 2002:a02:2708:: with SMTP id g8mr1921759jaa.52.1590511694529; Tue, 26 May 2020 09:48:14 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id d29sm250489ild.42.2020.05.26.09.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 09:48:13 -0700 (PDT) Subject: Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Greg Kroah-Hartman Cc: Ulf Hansson , linux-pci@vger.kernel.org, Bjorn Andersson , Pavel Machek , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Kevin Hilman , Julian Wiedmann , linux-acpi@vger.kernel.org, Jakub Kicinski , Dan Carpenter , Len Brown , linux-pm@vger.kernel.org, "James E.J. Bottomley" , Ursula Braun , Johan Hovold , greybus-dev@lists.linaro.org, John Stultz , Bjorn Helgaas , Felipe Balbi , Alex Elder , "Martin K. Petersen" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Karsten Graul , "David S. Miller" References: <20200525182608.1823735-1-kw@linux.com> <20200525182608.1823735-9-kw@linux.com> <20200526063521.GC2578492@kroah.com> <20200526150744.GC75990@rocinante> From: Alex Elder Message-ID: Date: Tue, 26 May 2020 11:48:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200526150744.GC75990@rocinante> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote: > Hello Greg, > > [...] >> It's "interesting" how using your new helper doesn't actually make the >> code smaller. Perhaps it isn't a good helper function? Helper functions often improve code readability, which is beneficial even if it doesn't reduce code size or efficiency. But I won't argue for or against this particular change. It's OK with me either way. -Alex > The idea for the helper was inspired by the comment Dan made to Bjorn > about Bjorn's change, as per: > > https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/ > > It looked like a good idea to try to reduce the following: > > dev->driver && dev->driver->pm && dev->driver->pm->prepare > > Into something more succinct. Albeit, given the feedback from yourself > and Rafael, I gather that this helper is not really a good addition. > > Thank you everyone and sorry for the commotion! > > Krzysztof > _______________________________________________ > greybus-dev mailing list > greybus-dev@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/greybus-dev >