From: Finn Thain <fthain@telegraphics.com.au>
To: Kars de Jong <jongk@linux-m68k.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
schmitzmic@gmail.com
Subject: Re: [PATCH v2] zorro_esp: Limit DMA transfers to 65536 bytes (except on Fastlane)
Date: Wed, 13 Nov 2019 09:46:10 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1.1911130945480.13@nippy.intranet> (raw)
In-Reply-To: <20191112175523.23145-1-jongk@linux-m68k.org>
On Tue, 12 Nov 2019, Kars de Jong wrote:
> When using this driver on a Blizzard 1260, there were failures whenever
> DMA transfers from the SCSI bus to memory of 65535 bytes were followed by a
> DMA transfer of 1 byte. This caused the byte at offset 65535 to be
> overwritten with 0xff. The Blizzard hardware can't handle single byte DMA
> transfers.
>
> Besides this issue, limiting the DMA length to something that is not a
> multiple of the page size is very inefficient on most file systems.
>
> It seems this limit was chosen because the DMA transfer counter of the ESP
> by default is 16 bits wide, thus limiting the length to 65535 bytes.
> However, the value 0 means 65536 bytes, which is handled by the ESP and the
> Blizzard just fine. It is also the default maximum used by esp_scsi when
> drivers don't provide their own dma_length_limit() function.
>
> The limit of 65536 bytes can be used by all boards except the Fastlane. The
> old driver used a limit of 65532 bytes (0xfffc), which is reintroduced in
> this patch.
>
> Fixes: b7ded0e8b0d1 ("scsi: zorro_esp: Limit DMA transfers to 65535 bytes")
> Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/zorro_esp.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/zorro_esp.c b/drivers/scsi/zorro_esp.c
> index ca8e3abeb2c7..a23a8e5794f5 100644
> --- a/drivers/scsi/zorro_esp.c
> +++ b/drivers/scsi/zorro_esp.c
> @@ -218,7 +218,14 @@ static int fastlane_esp_irq_pending(struct esp *esp)
> static u32 zorro_esp_dma_length_limit(struct esp *esp, u32 dma_addr,
> u32 dma_len)
> {
> - return dma_len > 0xFFFF ? 0xFFFF : dma_len;
> + return dma_len > (1U << 16) ? (1U << 16) : dma_len;
> +}
> +
> +static u32 fastlane_esp_dma_length_limit(struct esp *esp, u32 dma_addr,
> + u32 dma_len)
> +{
> + /* The old driver used 0xfffc as limit, so do that here too */
> + return dma_len > 0xfffc ? 0xfffc : dma_len;
> }
>
> static void zorro_esp_reset_dma(struct esp *esp)
> @@ -604,7 +611,7 @@ static const struct esp_driver_ops fastlane_esp_ops = {
> .esp_write8 = zorro_esp_write8,
> .esp_read8 = zorro_esp_read8,
> .irq_pending = fastlane_esp_irq_pending,
> - .dma_length_limit = zorro_esp_dma_length_limit,
> + .dma_length_limit = fastlane_esp_dma_length_limit,
> .reset_dma = zorro_esp_reset_dma,
> .dma_drain = zorro_esp_dma_drain,
> .dma_invalidate = fastlane_esp_dma_invalidate,
>
next prev parent reply other threads:[~2019-11-12 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACz-3rh9ZCyU1825yU8xxty5BGrwFhpbjKNoWnn0mGiv_h2Kag@mail.gmail.com>
2019-11-09 19:14 ` [PATCH] zorro_esp: increase maximum dma length to 65536 bytes Kars de Jong
2019-11-09 20:12 ` James Bottomley
2019-11-10 2:36 ` Michael Schmitz
2019-11-10 9:01 ` Kars de Jong
2019-11-10 19:26 ` Michael Schmitz
2019-11-11 8:47 ` Kars de Jong
2019-11-10 19:35 ` James Bottomley
2019-11-12 17:55 ` [PATCH v2] zorro_esp: Limit DMA transfers to 65536 bytes (except on Fastlane) Kars de Jong
2019-11-12 22:46 ` Finn Thain [this message]
2019-11-13 2:27 ` Martin K. Petersen
2019-11-12 9:34 ` [PATCH] zorro_esp: increase maximum dma length to 65536 bytes Kars de Jong
2019-11-09 22:53 ` Finn Thain
2019-11-10 9:06 ` Kars de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1.1911130945480.13@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=jejb@linux.ibm.com \
--cc=jongk@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).