From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D1EC433F5 for ; Mon, 13 Dec 2021 10:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237570AbhLMKc7 (ORCPT ); Mon, 13 Dec 2021 05:32:59 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4253 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235771AbhLMKbZ (ORCPT ); Mon, 13 Dec 2021 05:31:25 -0500 Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JCHmx2DY8z67Cxd; Mon, 13 Dec 2021 18:29:21 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 13 Dec 2021 11:31:23 +0100 Received: from [10.47.83.94] (10.47.83.94) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 13 Dec 2021 10:31:22 +0000 Subject: Re: [PATCH 02/15] Revert "scsi: hisi_sas: Filter out new PHY up events during suspend" To: chenxiang , , CC: , References: <1637117108-230103-1-git-send-email-chenxiang66@hisilicon.com> <1637117108-230103-3-git-send-email-chenxiang66@hisilicon.com> From: John Garry Message-ID: Date: Mon, 13 Dec 2021 10:31:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <1637117108-230103-3-git-send-email-chenxiang66@hisilicon.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.94] X-ClientProxiedBy: lhreml701-chm.china.huawei.com (10.201.108.50) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 17/11/2021 02:44, chenxiang wrote: > From: John Garry > > This reverts commit b14a37e011d829404c29a5ae17849d7efb034893. > > In that commit, we had to filter out phy-up events during suspend, as it > work cause a deadlock between processing the phyup event and the resume > HA function try to drain the HA event workqueue to complete the resume > process. > > Now that we no longer try to drain the HA event queue during the HA > resume processor, the deadlock would not occur, so remove the special > handling for it. > > Signed-off-by: John Garry This is missing your Signed-off-by Thanks, John