Re: [PATCH] SCSI: FlashPoint: rename si_flags field

[Hannes Reinecke <hare@suse.de>]

On 5/30/21 1:48 AM, Randy Dunlap wrote:
> The BusLogic driver has build errors on ia64 due to a name collision
> (in the #included FlashPoint.c file).
> Rename the struct field in struct sccb_mgr_info from si_flags to
> si_mflags (manager flags) to mend the build.
> 
> This is the first problem. There are 50+ others after this one:
> 
> In file included from ../include/uapi/linux/signal.h:6,
>                   from ../include/linux/signal_types.h:10,
>                   from ../include/linux/sched.h:29,
>                   from ../include/linux/hardirq.h:9,
>                   from ../include/linux/interrupt.h:11,
>                   from ../drivers/scsi/BusLogic.c:27:
> ../arch/ia64/include/uapi/asm/siginfo.h:15:27: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token
>     15 | #define si_flags _sifields._sigfault._flags
>        |                           ^
> ../drivers/scsi/FlashPoint.c:43:6: note: in expansion of macro 'si_flags'
>     43 |  u16 si_flags;
>        |      ^~~~~~~~
> In file included from ../drivers/scsi/BusLogic.c:51:
> ../drivers/scsi/FlashPoint.c: In function 'FlashPoint_ProbeHostAdapter':
> ../drivers/scsi/FlashPoint.c:1076:11: error: 'struct sccb_mgr_info' has no member named '_sifields'
>   1076 |  pCardInfo->si_flags = 0x0000;
>        |           ^~
> ../drivers/scsi/FlashPoint.c:1079:12: error: 'struct sccb_mgr_info' has no member named '_sifields'
> 
> Fixes: 391e2f25601e ("[SCSI] BusLogic: Port driver to 64-bit.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Khalid Aziz <khalid.aziz@oracle.com>
> Cc: Khalid Aziz <khalid@gonehiking.org>
> ---
>   drivers/scsi/FlashPoint.c |   32 ++++++++++++++++----------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer