From: John Garry <john.garry@huawei.com>
To: Bart Van Assche <bvanassche@acm.org>, <axboe@kernel.dk>,
<damien.lemoal@opensource.wdc.com>, <hch@lst.de>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<hare@suse.de>, <satishkh@cisco.com>, <sebaddel@cisco.com>,
<kartilak@cisco.com>
Cc: <linux-rdma@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<linux-nvme@lists.infradead.org>, <linux-s390@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <mpi3mr-linuxdrv.pdl@broadcom.com>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nbd@other.debian.org>
Subject: Re: [PATCH 5/5] blk-mq: Drop 'reserved' member of busy_tag_iter_fn
Date: Mon, 20 Jun 2022 12:12:55 +0100 [thread overview]
Message-ID: <b98ad03b-e599-6023-3b34-ebefb590bf8c@huawei.com> (raw)
In-Reply-To: <c6a0eb8d-ad51-01b1-bc17-758acc37f216@acm.org>
On 17/06/2022 17:55, Bart Van Assche wrote:
>>
>> It's not totally necessary. Since local variable 'reserved' would now
>> only be used once I thought it was better to get rid of it.
>>
>> I can keep it if you really think that is better.
>
> I'd prefer that these changes are either left out or that these are
> moved into a separate patch. I think that will make this patch series
> easier to review.
Personally I think that this is a trivial change and does not merit a
separate patch. Other reviewers seem to agree. Anyway, if you feel
strongly about this then I can put in another patch.
Thanks,
John
next prev parent reply other threads:[~2022-06-20 11:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 10:55 [PATCH 0/5] blk-mq: Add a flag for reserved requests series John Garry
2022-06-17 10:55 ` [PATCH 1/5] scsi: core: Remove reserved request time-out handling John Garry
2022-06-17 16:25 ` Bart Van Assche
2022-06-20 5:58 ` Christoph Hellwig
2022-06-20 7:37 ` John Garry
2022-06-20 9:14 ` Hannes Reinecke
2022-06-17 10:55 ` [PATCH 2/5] blk-mq: Add a flag for reserved requests John Garry
2022-06-20 9:15 ` Hannes Reinecke
2022-06-17 10:55 ` [PATCH 3/5] blk-mq: Drop blk_mq_ops.timeout 'reserved' arg John Garry
2022-06-17 16:29 ` Bart Van Assche
2022-06-20 5:59 ` Christoph Hellwig
2022-06-20 9:15 ` Hannes Reinecke
2022-06-17 10:55 ` [PATCH 4/5] scsi: fnic: Drop reserved request handling John Garry
2022-06-17 16:29 ` Bart Van Assche
2022-06-20 5:59 ` Christoph Hellwig
2022-06-20 9:15 ` Hannes Reinecke
2022-06-17 10:55 ` [PATCH 5/5] blk-mq: Drop 'reserved' member of busy_tag_iter_fn John Garry
2022-06-17 16:33 ` Bart Van Assche
2022-06-17 16:42 ` John Garry
2022-06-17 16:55 ` Bart Van Assche
2022-06-20 11:12 ` John Garry [this message]
2022-06-20 6:00 ` Christoph Hellwig
2022-06-20 9:16 ` Hannes Reinecke
2022-06-22 0:51 ` [PATCH 0/5] blk-mq: Add a flag for reserved requests series Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98ad03b-e599-6023-3b34-ebefb590bf8c@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=nbd@other.debian.org \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).