From: Bart Van Assche <bvanassche@acm.org>
To: Kanchan Joshi <joshi.k@samsung.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v8 05/19] block, fs: Restore the per-bio/request data lifetime fields
Date: Mon, 22 Jan 2024 12:05:30 -0800 [thread overview]
Message-ID: <bbaf780c-2807-44df-93b4-f3c9f6c43fad@acm.org> (raw)
In-Reply-To: <23354a9b-dd1e-5eed-f537-6a2de9185d7a@samsung.com>
On 1/22/24 01:23, Kanchan Joshi wrote:
> On 12/19/2023 5:37 AM, Bart Van Assche wrote:
>
>> diff --git a/block/fops.c b/block/fops.c
>> index 0abaac705daf..787ce52bc2c6 100644
>> --- a/block/fops.c
>> +++ b/block/fops.c
>> @@ -73,6 +73,7 @@ static ssize_t __blkdev_direct_IO_simple(struct kiocb *iocb,
>> bio_init(&bio, bdev, vecs, nr_pages, dio_bio_write_op(iocb));
>> }
>> bio.bi_iter.bi_sector = pos >> SECTOR_SHIFT;
>> + bio.bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint;
>> bio.bi_ioprio = iocb->ki_ioprio;
>>
>> ret = bio_iov_iter_get_pages(&bio, iter);
>> @@ -203,6 +204,7 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
>>
>> for (;;) {
>> bio->bi_iter.bi_sector = pos >> SECTOR_SHIFT;
>> + bio->bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint;
>> bio->bi_private = dio;
>> bio->bi_end_io = blkdev_bio_end_io;
>> bio->bi_ioprio = iocb->ki_ioprio;
>> @@ -321,6 +323,7 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb,
>> dio->flags = 0;
>> dio->iocb = iocb;
>> bio->bi_iter.bi_sector = pos >> SECTOR_SHIFT;
>> + bio->bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint;
>
> This (and two more places above) should rather be changed to:
>
> bio.bi_write_hint = bdev_file_inode(iocb->ki_filp)->i_write_hint;
>
> Note that at other places too (e.g., blkdev_fallocate, blkdev_mmap,
> blkdev_lseek) bdev inode is used and not file inode.
Why should this code be changed? The above code has been tested and
works fine.
Thanks,
Bart.
next prev parent reply other threads:[~2024-01-22 20:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 0:07 [PATCH v8 00/19] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 01/19] fs: Fix rw_hint validation Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 02/19] fs: Verify write lifetime constants at compile time Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 03/19] fs: Split fcntl_rw_hint() Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 04/19] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 05/19] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2024-01-22 9:23 ` Kanchan Joshi
2024-01-22 20:05 ` Bart Van Assche [this message]
2024-01-23 12:35 ` Kanchan Joshi
2024-01-23 15:59 ` Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 06/19] block, fs: Propagate write hints to the block device inode Bart Van Assche
2023-12-28 7:12 ` Christoph Hellwig
2023-12-28 22:41 ` Bart Van Assche
2024-01-03 9:02 ` Christoph Hellwig
2024-01-03 23:09 ` Bart Van Assche
2024-01-04 6:08 ` Christoph Hellwig
2024-01-18 18:51 ` Kanchan Joshi
2024-01-18 18:54 ` Bart Van Assche
2024-01-19 13:56 ` Kanchan Joshi
2024-01-22 9:31 ` Kanchan Joshi
2024-01-22 20:09 ` Bart Van Assche
2024-01-23 12:16 ` Kanchan Joshi
2024-01-23 15:29 ` Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 07/19] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 08/19] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 09/19] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 10/19] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 11/19] scsi: sd: Translate data lifetime information Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 12/19] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 13/19] scsi: scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 14/19] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 15/19] scsi: scsi_debug: Rework subpage " Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 16/19] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 17/19] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 18/19] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 19/19] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche
2023-12-19 1:12 ` [PATCH v8 00/19] Pass data lifetime information to SCSI disk devices Jens Axboe
2023-12-27 16:25 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbaf780c-2807-44df-93b4-f3c9f6c43fad@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).