Re: [PATCH v2 31/32] elx: efct: Add Makefile and Kconfig for efct driver

From: Hannes Reinecke <hare@suse.de>
To: James Smart <jsmart2021@gmail.com>, linux-scsi@vger.kernel.org
Cc: maier@linux.ibm.com, dwagner@suse.de, bvanassche@acm.org,
	Ram Vegesna <ram.vegesna@broadcom.com>
Subject: Re: [PATCH v2 31/32] elx: efct: Add Makefile and Kconfig for efct driver
Date: Thu, 9 Jan 2020 12:47:12 +0100	[thread overview]
Message-ID: <bc57009a-4f5a-3595-8c57-0289a2e1dc03@suse.de> (raw)
In-Reply-To: <20191220223723.26563-32-jsmart2021@gmail.com>

On 12/20/19 11:37 PM, James Smart wrote:
> This patch completes the efct driver population.
> 
> This patch adds driver definitions for:
> Adds the efct driver Kconfig and Makefiles
> 
> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>  drivers/scsi/elx/Kconfig  |  9 +++++++++
>  drivers/scsi/elx/Makefile | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
>  create mode 100644 drivers/scsi/elx/Kconfig
>  create mode 100644 drivers/scsi/elx/Makefile
> 
> diff --git a/drivers/scsi/elx/Kconfig b/drivers/scsi/elx/Kconfig
> new file mode 100644
> index 000000000000..ec710ade44f3
> --- /dev/null
> +++ b/drivers/scsi/elx/Kconfig
> @@ -0,0 +1,9 @@
> +config SCSI_EFCT
> +	tristate "Emulex Fibre Channel Target"
> +	depends on PCI && SCSI
> +	depends on TARGET_CORE
> +	depends on SCSI_FC_ATTRS
> +	select CRC_T10DIF
> +	help
> +          The efct driver provides enhanced SCSI Target Mode
> +	  support for specific SLI-4 adapters.
> diff --git a/drivers/scsi/elx/Makefile b/drivers/scsi/elx/Makefile
> new file mode 100644
> index 000000000000..79cc4e57676e
> --- /dev/null
> +++ b/drivers/scsi/elx/Makefile
> @@ -0,0 +1,30 @@
> +#/*******************************************************************
> +# * This file is part of the Emulex Linux Device Driver for         *
> +# * Fibre Channel Host Bus Adapters.                                *
> +# * Copyright (C) 2018 Broadcom. All Rights Reserved. The term	   *
> +# * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
> +# *                                                                 *
> +# * This program is free software; you can redistribute it and/or   *
> +# * modify it under the terms of version 2 of the GNU General       *
> +# * Public License as published by the Free Software Foundation.    *
> +# * This program is distributed in the hope that it will be useful. *
> +# * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND          *
> +# * WARRANTIES, INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY,  *
> +# * FITNESS FOR A PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE      *
> +# * DISCLAIMED, EXCEPT TO THE EXTENT THAT SUCH DISCLAIMERS ARE HELD *
> +# * TO BE LEGALLY INVALID.  See the GNU General Public License for  *
> +# * more details, a copy of which can be found in the file COPYING  *
> +# * included with this package.                                     *
> +# ********************************************************************/
> +

Use SPDX identifier here.

> +obj-$(CONFIG_SCSI_EFCT) := efct.o
> +
> +efct-objs := efct/efct_driver.o efct/efct_io.o efct/efct_scsi.o efct/efct_els.o \
> +	     efct/efct_xport.o efct/efct_hw.o efct/efct_hw_queues.o \
> +	     efct/efct_utils.o efct/efct_lio.o efct/efct_unsol.o
> +
> +efct-objs += libefc/efc_domain.o libefc/efc_fabric.o libefc/efc_node.o \
> +	     libefc/efc_sport.o libefc/efc_device.o \
> +	     libefc/efc_lib.o libefc/efc_sm.o
> +
> +efct-objs += libefc_sli/sli4.o
> 
Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      Teamlead Storage & Networking
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer