From: Hannes Reinecke <hare@suse.de>
To: tasleson@redhat.com, Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, b.zolnierkie@samsung.com,
axboe@kernel.dk
Subject: Re: [v4 00/11] Add persistent durable identifier to storage log messages
Date: Mon, 27 Jul 2020 18:46:51 +0200 [thread overview]
Message-ID: <bd1fb6dc-9fc1-0ee2-13a4-d221f28442c6@suse.de> (raw)
In-Reply-To: <e3184753-bda1-fcfd-5cc2-7aa865d420fd@redhat.com>
On 7/27/20 5:45 PM, Tony Asleson wrote:
> On 7/26/20 10:10 AM, Christoph Hellwig wrote:
>> FYI, I think these identifiers are absolutely horrible and have no
>> business in dmesg:
>
> The identifiers are structured data, they're not visible unless you go
> looking for them.
>
> I'm open to other suggestions on how we can positively identify storage
> devices over time, across reboots, replacement, and dynamic reconfiguration.
>
> My home system has 4 disks, 2 are identical except for serial number.
> Even with this simple configuration, it's not trivial to identify which
> message goes with which disk across reboots.
>
Well; the more important bits would be to identify the physical location
where these disks reside.
If one goes bad it doesn't really help you if have a persistent
identification in the OS; what you really need is a physical indicator
or a physical location allowing you to identify which disk to pull.
Which isn't addressed at all with this patchset (nor should it; the
physical location it typically found via other means).
And for the other use-cases: We do have persistent device links, do we
not? They provide even more information that you'd extract with this
this patchset, and don't require any kernel changes whatsoever.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-07-27 16:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 17:16 [v4 00/11] Add persistent durable identifier to storage log messages Tony Asleson
2020-07-24 17:16 ` [v4 01/11] struct device: Add function callback durable_name Tony Asleson
2020-07-24 17:16 ` [v4 02/11] create_syslog_header: Add durable name Tony Asleson
2020-07-24 17:16 ` [v4 03/11] dev_vprintk_emit: Increase hdr size Tony Asleson
2020-07-25 10:05 ` Andy Shevchenko
2020-08-26 18:26 ` Tony Asleson
2020-07-24 17:16 ` [v4 04/11] scsi: Add durable_name for dev_printk Tony Asleson
2020-07-25 10:20 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 05/11] nvme: Add durable name " Tony Asleson
2020-07-25 9:05 ` Sergei Shtylyov
2020-07-25 10:23 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 06/11] libata: Add ata_scsi_durable_name Tony Asleson
2020-07-25 0:48 ` kernel test robot
2020-07-25 1:07 ` kernel test robot
2020-07-25 1:07 ` [RFC PATCH] libata: ata_scsi_durable_name() can be static kernel test robot
2020-07-25 1:18 ` [v4 06/11] libata: Add ata_scsi_durable_name kernel test robot
2020-07-25 10:26 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 07/11] Add durable_name_printk Tony Asleson
2020-07-24 17:17 ` [v4 08/11] libata: use durable_name_printk Tony Asleson
2020-07-24 17:17 ` [v4 09/11] Add durable_name_printk_ratelimited Tony Asleson
2020-07-24 17:17 ` [v4 10/11] print_req_error: Use durable_name_printk_ratelimited Tony Asleson
2020-07-25 9:15 ` Sergei Shtylyov
2020-07-24 17:17 ` [v4 11/11] buffer_io_error: " Tony Asleson
2020-07-25 10:29 ` Andy Shevchenko
2020-07-26 15:10 ` [v4 00/11] Add persistent durable identifier to storage log messages Christoph Hellwig
2020-07-27 15:45 ` Tony Asleson
2020-07-27 16:46 ` Hannes Reinecke [this message]
2020-07-27 17:42 ` Tony Asleson
2020-07-27 19:17 ` Douglas Gilbert
2020-07-27 20:27 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd1fb6dc-9fc1-0ee2-13a4-d221f28442c6@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tasleson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).