From: bugzilla-daemon@kernel.org
To: linux-scsi@vger.kernel.org
Subject: [Bug 216413] New: [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems
Date: Thu, 25 Aug 2022 21:24:23 +0000 [thread overview]
Message-ID: <bug-216413-11613@https.bugzilla.kernel.org/> (raw)
https://bugzilla.kernel.org/show_bug.cgi?id=216413
Bug ID: 216413
Summary: [BISECT INCLUDED] scsi/sd Rework asynchronous resume
support breaks S2idle and S3 on several systems
Product: IO/Storage
Version: 2.5
Kernel Version: 6.0.0-rc1
Hardware: Intel
OS: Linux
Tree: Mainline
Status: NEW
Severity: blocking
Priority: P1
Component: SCSI
Assignee: bvanassche@acm.org
Reporter: todd.e.brandt@intel.com
CC: bvanassche@acm.org, lenb@kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Blocks: 178231
Regression: No
A commit in 6.0.0-rc1 has caused S2idle and S3 (freeze & mem) to completely
hang the system on these 4 machines in our lab:
1) Clevo System76 Lemur 6
2) Lenovo Yoga 2 Pro
3) Dell Inspiron 3493
4) HP Pavillion x360
To reproduce the issue simply run kernel 6.0.0-rc1 or newer on these systems
and run "sudo sleepgraph -m freeze" or "sudo sleepgraph -m mem". The system
will hang after that.
I've bisected the problem to this specific commit:
88f1669019bd62b3009a3cebf772fbaaa21b9f38 is the first bad commit
commit 88f1669019bd62b3009a3cebf772fbaaa21b9f38
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jun 30 12:57:03 2022 -0700
scsi: sd: Rework asynchronous resume support
For some technologies, e.g. an ATA bus, resuming can take multiple
seconds. Waiting for resume to finish can cause a very noticeable delay.
Hence this commit that restores the behavior from before "scsi: core: pm:
Rely on the device driver core for async power management" for most SCSI
devices.
This commit introduces a behavior change: if the START command fails, do
not consider this as a SCSI disk resume failure.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215880
Link: https://lore.kernel.org/r/20220630195703.10155-3-bvanassche@acm.org
Fixes: a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for
async power management")
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: John Garry <john.garry@huawei.com>
Cc: ericspero@icloud.com
Cc: jason600.groome@gmail.com
Tested-by: jason600.groome@gmail.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
:040000 040000 dbd390c19cfddba2b559b06691404aee4c165384
54c7fa67e3a1605878999bdf1e39a95ca793238a M drivers
Referenced Bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=178231
[Bug 178231] Meta-bug: Linux suspend-to-mem and freeze performance optimization
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2022-08-25 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 21:24 bugzilla-daemon [this message]
2022-08-25 21:27 ` [Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems bugzilla-daemon
2022-08-25 21:30 ` bugzilla-daemon
2022-08-25 21:32 ` bugzilla-daemon
2022-08-25 21:35 ` bugzilla-daemon
2022-08-25 21:38 ` bugzilla-daemon
2022-08-25 21:46 ` bugzilla-daemon
2022-08-25 21:55 ` bugzilla-daemon
2022-08-25 22:12 ` bugzilla-daemon
2022-08-29 22:37 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-216413-11613@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).