From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 13/15] scsi: core: Add helper to return number of logical blocks in a request
Date: Wed, 9 Jun 2021 20:40:35 -0700 [thread overview]
Message-ID: <c042a828-d8b2-f8f0-192b-4037de243547@acm.org> (raw)
In-Reply-To: <yq1im2mflzw.fsf@ca-mkp.ca.oracle.com>
On 6/9/21 8:19 PM, Martin K. Petersen wrote:
>> On 6/8/21 8:39 PM, Martin K. Petersen wrote:
>>> +static inline unsigned int scsi_get_block_count(struct scsi_cmnd *scmd)
>>> +{
>>> + unsigned int shift = ilog2(scmd->device->sector_size) - SECTOR_SHIFT;
>>> +
>>> + return blk_rq_bytes(scmd->request) >> shift;
>>> +}
>>
>> I think we either need a comment above this function that explains that
>> the return value is a number of logical blocks or to change the function
>> name to make the meaning of the return value clear.
>
> I went with the scsi_get_ prefix to match the scsi_get_sectors() and
> scsi_get_lba() calls. Felt that "block" would suffice but I could make
> it scsi_logical_block_count() if you prefer?
The name scsi_logical_block_count() sounds fine to me :-)
Thanks,
Bart.
next prev parent reply other threads:[~2021-06-10 3:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 3:39 [PATCH 00/15] Subject: Protection information and block size cleanup Martin K. Petersen
2021-06-09 3:39 ` [PATCH 01/15] scsi: core: Add scsi_prot_ref_tag() helper Martin K. Petersen
2021-06-09 19:55 ` Bart Van Assche
2021-06-14 14:33 ` Benjamin Block
2021-06-09 3:39 ` [PATCH 02/15] scsi: lpfc: Use the proper SCSI midlayer interfaces for PI Martin K. Petersen
2021-06-09 3:39 ` [PATCH 03/15] scsi: qla2xxx: " Martin K. Petersen
2021-06-17 0:15 ` Arun Easi
2021-06-09 3:39 ` [PATCH 04/15] scsi: mpt3sas: " Martin K. Petersen
2021-06-09 3:39 ` [PATCH 05/15] scsi: mpi3mr: " Martin K. Petersen
2021-06-09 3:39 ` [PATCH 06/15] scsi: zfcp: " Martin K. Petersen
2021-06-14 14:33 ` Benjamin Block
2021-06-15 2:27 ` Martin K. Petersen
2021-06-15 9:31 ` Benjamin Block
2021-06-09 3:39 ` [PATCH 07/15] scsi: isci: " Martin K. Petersen
2021-06-09 3:39 ` [PATCH 08/15] scsi: scsi_debug: Remove dump_sector() Martin K. Petersen
2021-06-09 19:55 ` Bart Van Assche
2021-06-14 22:06 ` Douglas Gilbert
2021-06-09 3:39 ` [PATCH 09/15] scsi: scsi_debug: Improve RDPROTECT/WRPROTECT handling Martin K. Petersen
2021-06-14 22:07 ` Douglas Gilbert
2021-06-09 3:39 ` [PATCH 10/15] scsi: core: Introduce scsi_get_sector() Martin K. Petersen
2021-06-14 14:48 ` Benjamin Block
2021-06-15 2:28 ` Martin K. Petersen
2021-06-15 9:33 ` Benjamin Block
2021-06-09 3:39 ` [PATCH 11/15] scsi: iser: Use scsi_get_sector() instead of scsi_get_lba() Martin K. Petersen
2021-06-09 3:39 ` [PATCH 12/15] scsi: core: Make scsi_get_lba() return the LBA Martin K. Petersen
2021-06-09 19:57 ` Bart Van Assche
2021-06-14 14:50 ` Benjamin Block
2021-06-15 9:34 ` Benjamin Block
2021-06-09 3:39 ` [PATCH 13/15] scsi: core: Add helper to return number of logical blocks in a request Martin K. Petersen
2021-06-09 19:58 ` Bart Van Assche
2021-06-10 3:19 ` Martin K. Petersen
2021-06-10 3:40 ` Bart Van Assche [this message]
2021-06-09 3:39 ` [PATCH 14/15] scsi: lpfc: Switch to scsi_get_block_count() Martin K. Petersen
2021-06-09 3:39 ` [PATCH 15/15] scsi: ufs: core: Use scsi_get_lba() to get LBA Martin K. Petersen
2021-06-09 19:59 ` Bart Van Assche
2021-07-16 21:27 ` [PATCH 00/15] Subject: Protection information and block size cleanup Bart Van Assche
2021-07-19 1:43 ` Martin K. Petersen
2021-07-21 3:53 ` Bart Van Assche
2021-07-24 2:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c042a828-d8b2-f8f0-192b-4037de243547@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).