From: John Garry <john.garry@huawei.com>
To: chenxiang <chenxiang66@hisilicon.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH 14/15] scsi: libsas: Keep sas host active until finished some work
Date: Tue, 14 Dec 2021 12:34:21 +0000 [thread overview]
Message-ID: <c05f5d30-bc2a-6933-4f27-589242fb84d4@huawei.com> (raw)
In-Reply-To: <1637117108-230103-15-git-send-email-chenxiang66@hisilicon.com>
Please consider som rewrite:
On 17/11/2021 02:45, chenxiang wrote:
"scsi: libsas: Keep sas host active until finished some work" -> "scsi:
libsas: Keep host active while processing events"
> From: Xiang Chen <chenxiang66@hisilicon.com>
>
> For those works from event queue, if executing them such as
> PORTE_BROADCAST_RCVD when sas host is suspended, it will resume sas host
> firstly as SMP IOs are sent in the process. So phyup will occur and it
> will call work PORTE_BYTES_DMAED. But the original work (such as
> PORTE_BROADCAST_RCVD) and the work PORTE_BYTES_DMAED are in the same
> singlethread workqueue, so the complete of original work waits for
> the complete of work PORTE_BYTES_DMAED while the complete of work
> PORTE_BYTES_DMAED wait for the complete of original and it is blocked.
>
> So call pm_runtime_get_noresume() to keep sas host active until
> finished those works.
Processing events such as PORTE_BROADCAST_RCVD may cause dependency
issues for runtime power management support.
Such a problem would be that handling a PORTE_BROADCAST_RCVD event
requires that the host is resumed to send SMP commands. However, in
resuming the host, the phyup events generated from re-enabling the phys
are processed in the same workqueue as the original PORTE_BROADCAST_RCVD
event. As such, the host will never finish resuming (as it waits for the
phyup event processing), and then the PORTE_BROADCAST_RCVD event cannot
be processed as the SMP commands are blocked, and so we have a deadlock.
Solve this problem by ensuring that libsas keeps the host active until
completely finished processing phy or port events, such as
PORTE_BYTES_DMAED. As such, we don't have to worry about resuming the
host for processing individual SMP commands in this example.
>
> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
> Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/libsas/sas_event.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_event.c b/drivers/scsi/libsas/sas_event.c
> index 626ef96b9348..3613b9b315bc 100644
> --- a/drivers/scsi/libsas/sas_event.c
> +++ b/drivers/scsi/libsas/sas_event.c
> @@ -50,8 +50,10 @@ void sas_queue_deferred_work(struct sas_ha_struct *ha)
> list_for_each_entry_safe(sw, _sw, &ha->defer_q, drain_node) {
> list_del_init(&sw->drain_node);
> ret = sas_queue_work(ha, sw);
> - if (ret != 1)
> + if (ret != 1) {
> + pm_runtime_put(ha->dev);
> sas_free_event(to_asd_sas_event(&sw->work));
> + }
> }
> spin_unlock_irq(&ha->lock);
> }
> @@ -126,16 +128,22 @@ void sas_enable_revalidation(struct sas_ha_struct *ha)
> static void sas_port_event_worker(struct work_struct *work)
> {
> struct asd_sas_event *ev = to_asd_sas_event(work);
> + struct asd_sas_phy *phy = ev->phy;
> + struct sas_ha_struct *ha = phy->ha;
>
> sas_port_event_fns[ev->event](work);
> + pm_runtime_put(ha->dev);
> sas_free_event(ev);
> }
>
> static void sas_phy_event_worker(struct work_struct *work)
> {
> struct asd_sas_event *ev = to_asd_sas_event(work);
> + struct asd_sas_phy *phy = ev->phy;
> + struct sas_ha_struct *ha = phy->ha;
>
> sas_phy_event_fns[ev->event](work);
> + pm_runtime_put(ha->dev);
> sas_free_event(ev);
> }
>
> @@ -170,14 +178,19 @@ int sas_notify_port_event(struct asd_sas_phy *phy, enum port_event event,
> if (!ev)
> return -ENOMEM;
>
> + /* Call pm_runtime_put() with pairs in sas_port_event_worker() */
> + pm_runtime_get_noresume(ha->dev);
> +
> INIT_SAS_EVENT(ev, sas_port_event_worker, phy, event);
>
> if (sas_defer_event(phy, ev))
> return 0;
>
> ret = sas_queue_event(event, &ev->work, ha);
> - if (ret != 1)
> + if (ret != 1) {
> + pm_runtime_put(ha->dev);
> sas_free_event(ev);
> + }
>
> return ret;
> }
> @@ -196,14 +209,19 @@ int sas_notify_phy_event(struct asd_sas_phy *phy, enum phy_event event,
> if (!ev)
> return -ENOMEM;
>
> + /* Call pm_runtime_put() with pairs in sas_phy_event_worker() */
> + pm_runtime_get_noresume(ha->dev);
> +
> INIT_SAS_EVENT(ev, sas_phy_event_worker, phy, event);
>
> if (sas_defer_event(phy, ev))
> return 0;
>
> ret = sas_queue_event(event, &ev->work, ha);
> - if (ret != 1)
> + if (ret != 1) {
> + pm_runtime_put(ha->dev);
> sas_free_event(ev);
> + }
>
> return ret;
> }
>
next prev parent reply other threads:[~2021-12-14 12:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 2:44 [PATCH 00/15] Add runtime PM support for libsas chenxiang
2021-11-17 2:44 ` [PATCH 01/15] libsas: Don't always drain event workqueue for HA resume chenxiang
2021-11-17 4:14 ` Bart Van Assche
2021-11-17 5:06 ` Bart Van Assche
2021-11-17 2:44 ` [PATCH 02/15] Revert "scsi: hisi_sas: Filter out new PHY up events during suspend" chenxiang
2021-12-13 10:31 ` John Garry
2021-12-15 7:20 ` chenxiang (M)
2021-11-17 2:44 ` [PATCH 03/15] scsi/block PM: Always set request queue runtime active in blk_post_runtime_resume() chenxiang
2021-11-17 4:58 ` Bart Van Assche
2021-11-17 2:44 ` [PATCH 04/15] scsi: libsas: Add spin_lock/unlock() to protect asd_sas_port->phy_list chenxiang
2021-11-17 2:44 ` [PATCH 05/15] scsi: hisi_sas: Fix some issues related to asd_sas_port->phy_list chenxiang
2021-11-17 2:44 ` [PATCH 06/15] scsi: mvsas: Add spin_lock/unlock() to protect asd_sas_port->phy_list chenxiang
2021-11-17 2:45 ` [PATCH 07/15] scsi: libsas: Send event PORTE_BROADCAST_RCVD for valid ports chenxiang
2021-12-13 11:02 ` John Garry
2021-12-15 7:25 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 08/15] scsi: hisi_sas: Add more prink for runtime suspend/resume chenxiang
2021-12-13 10:34 ` John Garry
2021-12-15 7:26 ` chenxiang (M)
2021-12-13 10:35 ` John Garry
2021-12-15 7:26 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 09/15] scsi: libsas: Resume sas host before sending SMP IOs chenxiang
2021-12-13 11:12 ` John Garry
2021-12-15 8:00 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 10/15] scsi: libsas: Add a flag SAS_HA_RESUMING of sas_ha chenxiang
2021-12-13 11:17 ` John Garry
2021-12-15 7:34 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 11/15] scsi: libsas: Refactor out sas_queue_deferred_work() chenxiang
2021-12-13 11:20 ` John Garry
2021-12-15 7:59 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 12/15] scsi: libsas: Defer works of new phys during suspend chenxiang
2021-11-17 2:45 ` [PATCH 13/15] scsi: hisi_sas: Keep controller active between ISR of phyup and the event being processed chenxiang
2021-12-13 10:44 ` John Garry
2021-12-15 7:57 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 14/15] scsi: libsas: Keep sas host active until finished some work chenxiang
2021-12-14 12:34 ` John Garry [this message]
2021-12-15 7:46 ` chenxiang (M)
2021-11-17 2:45 ` [PATCH 15/15] scsi: hisi_sas: Use autosuspend for SAS controller chenxiang
2021-12-13 10:50 ` John Garry
2021-12-15 7:52 ` chenxiang (M)
2021-11-19 4:04 ` [PATCH 00/15] Add runtime PM support for libsas Martin K. Petersen
2021-11-23 6:01 ` chenxiang (M)
2021-12-14 11:52 ` John Garry
2021-12-15 7:56 ` chenxiang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c05f5d30-bc2a-6933-4f27-589242fb84d4@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).