From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B4CC433DF for ; Wed, 20 May 2020 15:51:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A73982070A for ; Wed, 20 May 2020 15:51:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbgETPvY (ORCPT ); Wed, 20 May 2020 11:51:24 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:55234 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbgETPvY (ORCPT ); Wed, 20 May 2020 11:51:24 -0400 Received: by mail-pj1-f68.google.com with SMTP id s69so1477907pjb.4 for ; Wed, 20 May 2020 08:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UBXi6yeFFDdKRK0nmFFCzMjYkQbUjki2T3sociuVY3Y=; b=q75uZSHqpdeXRCl9kGAKyH3015bNv8SLo5MJRU4cqdevm9JpF4JjTwzCt2D8sjcArf 1gRGUF/X/Stv9aQd2V3s1wn7X15hbISPGkLhlvTJNthkE6r/2fd93+DvVNEdOXLgW94p 3mmln/3zRc7qh+k8Zm5w9v2NHvtyOkkGfttxxHv7cCzHJroYEVBJyU9urmQNXMRBMau9 M23JdO7gdJ8etXJsHnRQtUlCW+cILXJ9X2K92sq+ilhl1yFgZzp5KZRmBoZFOhmZQLFO tCjtu7KlyC9C2TkdC6f3KGMqB2lAeGZa+sNBLrRvs8F03liFUkFiQLpt/plRcyV2LMdi WTfA== X-Gm-Message-State: AOAM530fvqNqTHJugXCvY0QI8g2pFXlV7suhdtfw08dMleOhj8dN0HVn TzmGul3ZZT4goA2f8kk1fy4= X-Google-Smtp-Source: ABdhPJytkGoCBFHjheGoZfa31JtpHQsQp7uoLObDfkpHKPboqWaPWWjfGC166+sgaoUajxtdw7Bw0g== X-Received: by 2002:a17:902:30d:: with SMTP id 13mr5205041pld.197.1589989882960; Wed, 20 May 2020 08:51:22 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:c031:e55:f9a8:4282? ([2601:647:4000:d7:c031:e55:f9a8:4282]) by smtp.gmail.com with ESMTPSA id k13sm2767668pfd.14.2020.05.20.08.51.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2020 08:51:22 -0700 (PDT) Subject: Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls() To: Daniel Wagner , linux-scsi@vger.kernel.org Cc: Arun Easi , Nilesh Javali , Himanshu Madhani , Hannes Reinecke , Martin Wilck , Roman Bolshakov References: <20200520130819.90625-1-dwagner@suse.de> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Wed, 20 May 2020 08:51:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200520130819.90625-1-dwagner@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2020-05-20 06:08, Daniel Wagner wrote: > The function always returns QLA_SUCCESS and the caller > qla2x00_start_sp() doesn't even evalute the return value. So there is > no point in returning a status. Reviewed-by: Bart Van Assche