From: Kiwoong Kim <kwmad.kim@samsung.com>
To: linux-scsi@vger.kernel.org, alim.akhtar@samsung.com,
avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, beanhuo@micron.com,
asutoshd@codeaurora.org, cang@codeaurora.org, bvanassche@acm.org,
grant.jung@samsung.com, sc.suh@samsung.com, hy50.seo@samsung.com,
sh425.lee@samsung.com
Cc: Kiwoong Kim <kwmad.kim@samsung.com>
Subject: [RFC PATCH v5 3/3] ufs: exynos: implement dbg_register_dump
Date: Sat, 11 Jul 2020 15:57:45 +0900 [thread overview]
Message-ID: <c8a2e31269685692b456b278afb5113f46afe3ed.1594450408.git.kwmad.kim@samsung.com> (raw)
In-Reply-To: <cover.1594450408.git.kwmad.kim@samsung.com>
In-Reply-To: <cover.1594450408.git.kwmad.kim@samsung.com>
At present, I just add command history print and
you can add various vendor regions.
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/Kconfig | 2 +-
drivers/scsi/ufs/ufs-exynos-dbg.c | 2 --
drivers/scsi/ufs/ufs-exynos.c | 14 +++++++++++++-
drivers/scsi/ufs/ufs-exynos.h | 10 ++++++++--
4 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index c946d8f..b906ff8 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -181,7 +181,7 @@ config SCSI_UFS_EXYNOS_DBG
This selects EXYNOS specific functions to get and even print
some information to see what's happening at both command
issue time completion time.
- The information may contain gerernal things as well as
+ The information may contain general things as well as
EXYNOS specific, such as vendor specific hardware contexts.
Select this if you want to get and print the information.
diff --git a/drivers/scsi/ufs/ufs-exynos-dbg.c b/drivers/scsi/ufs/ufs-exynos-dbg.c
index a626b71..7fd7308 100644
--- a/drivers/scsi/ufs/ufs-exynos-dbg.c
+++ b/drivers/scsi/ufs/ufs-exynos-dbg.c
@@ -121,9 +121,7 @@ void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev)
mgr->time = cpu_clock(raw_smp_processor_id());
-#ifdef CONFIG_SCSI_UFS_EXYNOS_CMD_LOG
ufs_s_print_cmd_log(mgr, dev);
-#endif
if (mgr->first_time == 0ULL)
mgr->first_time = mgr->time;
diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index 53b9d6e..444aba1 100644
--- a/drivers/scsi/ufs/ufs-exynos.c
+++ b/drivers/scsi/ufs/ufs-exynos.c
@@ -1033,7 +1033,6 @@ static int exynos_ufs_init(struct ufs_hba *hba)
ret = exynos_ufs_init_dbg(&ufs->handle, dev);
if (ret)
return ret;
- spin_lock_init(&ufs->dbg_lock);
return 0;
phy_off:
@@ -1236,6 +1235,18 @@ static int exynos_ufs_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
return 0;
}
+static void exynos_ufs_dbg_register_dump(struct ufs_hba *hba)
+{
+ struct exynos_ufs *ufs = ufshcd_get_variant(hba);
+
+ if (!test_and_set_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag)) {
+ exynos_ufs_dump_info(&ufs->handle, hba->dev);
+ clear_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag);
+ }
+out:
+ return;
+}
+
static struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
.name = "exynos_ufs",
.init = exynos_ufs_init,
@@ -1248,6 +1259,7 @@ static struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
.hibern8_notify = exynos_ufs_hibern8_notify,
.suspend = exynos_ufs_suspend,
.resume = exynos_ufs_resume,
+ .dbg_register_dump = exynos_ufs_dbg_register_dump,
};
static int exynos_ufs_probe(struct platform_device *pdev)
diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
index b9cb517..3f242de 100644
--- a/drivers/scsi/ufs/ufs-exynos.h
+++ b/drivers/scsi/ufs/ufs-exynos.h
@@ -215,8 +215,8 @@ struct exynos_ufs {
#define EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER BIT(4)
struct ufs_exynos_handle handle;
- spinlock_t dbg_lock;
- int under_dump;
+ unsigned long dbg_flag;
+#define EXYNOS_UFS_DBG_DUMP_CXT BIT(0)
};
#define for_each_ufs_rx_lane(ufs, i) \
@@ -297,6 +297,7 @@ void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle,
void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle,
struct ufs_hba *hba, int tag);
int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev);
+void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev);
#else
void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle,
struct ufs_hba *hba, int tag)
@@ -312,5 +313,10 @@ int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev)
{
return 0;
}
+
+void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev)
+{
+ return 0;
+}
#endif
#endif /* _UFS_EXYNOS_H_ */
--
2.7.4
next prev parent reply other threads:[~2020-07-11 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200711070541epcas2p47678883840df461f649becfc73792da5@epcas2p4.samsung.com>
2020-07-11 6:57 ` [RFC PATCH v5 0/3] ufs: exynos: introduce the way to get cmd info Kiwoong Kim
[not found] ` <CGME20200711070543epcas2p28a42f8386624ecaede5329e035e5e1a9@epcas2p2.samsung.com>
2020-07-11 6:57 ` [RFC PATCH v5 1/3] ufs: introduce a callback to get info of command completion Kiwoong Kim
[not found] ` <CGME20200711070544epcas2p4d3a75d2f56b8162c09efa0eeaf012fa2@epcas2p4.samsung.com>
2020-07-11 6:57 ` [RFC PATCH v5 2/3] ufs: exynos: introduce command history Kiwoong Kim
2020-07-12 1:55 ` Alim Akhtar
2020-07-13 4:33 ` Kiwoong Kim
[not found] ` <CGME20200711070544epcas2p10291ef069c92d54a7cb8a6b7e0eb09a1@epcas2p1.samsung.com>
2020-07-11 6:57 ` Kiwoong Kim [this message]
2020-07-12 1:58 ` [RFC PATCH v5 0/3] ufs: exynos: introduce the way to get cmd info Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a2e31269685692b456b278afb5113f46afe3ed.1594450408.git.kwmad.kim@samsung.com \
--to=kwmad.kim@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=grant.jung@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).