linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
	Bart Van Assche <Bart.VanAssche@sandisk.com>
Subject: Re: [PATCH 1/2] scsi: add BLIST_RETRY_SCAN to ignore errors during scanning
Date: Wed, 22 Jun 2022 10:16:54 +0200	[thread overview]
Message-ID: <d409f1856e46c3df951eaac9eed14844c66961fa.camel@suse.com> (raw)
In-Reply-To: <yq15yktjw77.fsf@ca-mkp.ca.oracle.com>

On Tue, 2022-06-21 at 22:02 -0400, Martin K. Petersen wrote:
> 
> Martin,
> 
> > @@ -1531,9 +1536,10 @@ static int scsi_report_lun_scan(struct
> > scsi_target *starget, blist_flags_t bflag
> >                                     " allowed by the host
> > adapter\n", lun);
> >                 } else {
> >                         int res;
> > +                       blist_flags_t bflags = BLIST_RETRY_SCAN;
> 
> I'm not a big fan of using the bflag as carrier of "I was reported
> and
> therefore must exist".
> 
> Also: Why isn't patch #2 sufficient?

I think it is. I can resubmit just #2 if you prefer and Hannes agrees.

Regards,
Martin



  reply	other threads:[~2022-06-22  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 16:41 [PATCH 0/2] Fixes for device probing on flaky connections mwilck
2022-06-15 16:41 ` [PATCH 1/2] scsi: add BLIST_RETRY_SCAN to ignore errors during scanning mwilck
2022-06-22  2:02   ` Martin K. Petersen
2022-06-22  8:16     ` Martin Wilck [this message]
2022-06-22 10:49       ` Hannes Reinecke
2022-06-22 12:05         ` Martin Wilck
2022-06-15 16:41 ` [PATCH 2/2] scsi: scan: retry INQUIRY after timeout mwilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d409f1856e46c3df951eaac9eed14844c66961fa.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).