Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Can Guo <cang@codeaurora.org>,
	asutoshd@codeaurora.org, nguyenb@codeaurora.org,
	hongwus@codeaurora.org, rnayak@codeaurora.org,
	sh425.lee@samsung.com, linux-scsi@vger.kernel.org,
	kernel-team@android.com, saravanak@google.com,
	salyzyn@google.com
Subject: Re: [PATCH v7 0/8] Fix up and simplify error recovery mechanism
Date: Tue, 28 Jul 2020 23:44:36 +0200
Message-ID: <d48e32fa95a0cfb5d2f2d25e7a36ce2bdfe650fc.camel@gmail.com> (raw)
In-Reply-To: <1595912460-8860-1-git-send-email-cang@codeaurora.org>

On Mon, 2020-07-27 at 22:00 -0700, Can Guo wrote:
> The changes have been tested with error injections of multiple error
> types (and
> all kinds of mixture of them) during runtime, e.g. hibern8 enter/
> exit error,
> power mode change error and fatal/non-fatal error from IRQ context.
> During the
> test, error injections happen randomly across all contexts, e.g. clk
> scaling,
> clk gate/ungate, runtime suspend/resume and IRQ.
> 
> There are a few more fixes to resolve other minor problems based on
> the main
> change, such as LINERESET handling and racing btw error handler and
> system
> suspend/resume/shutdown, but they will be pushed after this series is
> taken,
> due to there are already too many lines in these changes.
> 
> Change since v6:
> - Modified change "scsi: ufs-qcom: Fix schedule while atomic error in
> ufs_qcom_dump_dbg_regs" to "scsi: ufs-qcom: Remove testbus dump in
> ufs_qcom_dump_dbg_regs"
> 
> Change since v5:
> - Dropped change "scsi: ufs: Fix imbalanced scsi_block_reqs_cnt
> caused by ufshcd_hold()" as it is not quite related with this series
> - Refined func ufshcd_err_handling_prepare in change "scsi: ufs:
> Recover hba runtime PM error in error handler"
> 
> Change since v4:
> - Split the original change "ufs: ufs-qcom: Fix a few BUGs in func
> ufs_qcom_dump_dbg_regs()" to 2 small changes
> 
> Change since v3:
> - Split the original change "scsi: ufs: Fix up and simplify error
> recovery mechanism" into 5 changes
> 
> Change since v2:
> - Incorporate Bart's comment to change "scsi: ufs: Add checks before
> setting clk-gating states"
> - Revised the commit msg of change "scsi: ufs: Fix up and simplify
> error recovery mechanism"
> 
> Change since v1:
> - Fixed a compilation error in case that CONFIG_PM is N
> 
> Can Guo (8):
>   scsi: ufs: Add checks before setting clk-gating states
>   ufs: ufs-qcom: Fix race conditions caused by func
>     ufs_qcom_testbus_config
>   scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs
>   scsi: ufs: Add some debug infos to ufshcd_print_host_state
>   scsi: ufs: Fix concurrency of error handler and other error
> recovery
>     paths
>   scsi: ufs: Recover hba runtime PM error in error handler
>   scsi: ufs: Move dumps in IRQ handler to error handler
>   scsi: ufs: Fix a racing problem btw error handler and runtime PM
> ops
> 
>  drivers/scsi/ufs/ufs-qcom.c  |  37 ----
>  drivers/scsi/ufs/ufs-sysfs.c |   1 +
>  drivers/scsi/ufs/ufshcd.c    | 494 +++++++++++++++++++++++++++----
> ------------
>  drivers/scsi/ufs/ufshcd.h    |  15 ++
>  4 files changed, 324 insertions(+), 223 deletions(-)
> 
This series looks good to me.
Reviewed-by: Bean Huo <beanhuo@micron.com>

Thanks,
Bean



      parent reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28  5:00 Can Guo
2020-07-28  5:00 ` [PATCH v7 1/8] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-29  6:47   ` Stanley Chu
2020-07-28  5:00 ` [PATCH v7 2/8] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-07-28  5:00 ` [PATCH v7 3/8] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs Can Guo
2020-07-28  5:32   ` hongwus
2020-07-28  7:53   ` Avri Altman
2020-07-28  5:00 ` [PATCH v7 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-07-28  5:32   ` hongwus
2020-07-28 18:01   ` Asutosh Das (asd)
2020-07-29  7:00   ` Stanley Chu
2020-07-28  5:00 ` [PATCH v7 5/8] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-07-28  5:00 ` [PATCH v7 6/8] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-07-28  5:00 ` [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-07-28 18:06   ` Asutosh Das (asd)
2020-07-29 13:02     ` Can Guo
2020-07-29 22:45       ` Asutosh Das (asd)
2020-07-28  5:00 ` [PATCH v7 8/8] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
2020-07-28 21:44 ` Bean Huo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d48e32fa95a0cfb5d2f2d25e7a36ce2bdfe650fc.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=hongwus@codeaurora.org \
    --cc=kernel-team@android.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nguyenb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=sh425.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git