From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Can Guo <cang@codeaurora.org>
Cc: nguyenb@codeaurora.org, hongwus@codeaurora.org,
rnayak@codeaurora.org, sh425.lee@samsung.com,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to error handler
Date: Wed, 29 Jul 2020 15:45:31 -0700 [thread overview]
Message-ID: <d66389fa-4ca2-bf7e-6b3d-d77eada4eb0e@codeaurora.org> (raw)
In-Reply-To: <dff9541177ebf68950ca13d2f13d88ba@codeaurora.org>
On 7/29/2020 6:02 AM, Can Guo wrote:
> Hi Asutosh,
>
> On 2020-07-29 02:06, Asutosh Das (asd) wrote:
>> On 7/27/2020 10:00 PM, Can Guo wrote:
>>> Sometime dumps in IRQ handler are heavy enough to cause system stability
>>> issues, move them to error handler.
>>>
>>> Signed-off-by: Can Guo <cang@codeaurora.org>
>>> ---
>>> drivers/scsi/ufs/ufshcd.c | 31 +++++++++++++++----------------
>>> 1 file changed, 15 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>> index c480823..b2bafa3 100644
>>> --- a/drivers/scsi/ufs/ufshcd.c
>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>> @@ -5682,6 +5682,21 @@ static void ufshcd_err_handler(struct
>>> work_struct *work)
>>> UFSHCD_UIC_DL_TCx_REPLAY_ERROR))))
>>> needs_reset = true;
>>> + if (hba->saved_err & (INT_FATAL_ERRORS | UIC_ERROR |
>>> + UFSHCD_UIC_HIBERN8_MASK)) {
>>> + bool pr_prdt = !!(hba->saved_err & SYSTEM_BUS_FATAL_ERROR);
>>> +
>>> + dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",
>>> + __func__, hba->saved_err, hba->saved_uic_err);
>>> + spin_unlock_irqrestore(hba->host->host_lock, flags);
>>> + ufshcd_print_host_state(hba);
>>> + ufshcd_print_pwr_info(hba);
>>> + ufshcd_print_host_regs(hba);
>>> + ufshcd_print_tmrs(hba, hba->outstanding_tasks);
>>> + ufshcd_print_trs(hba, hba->outstanding_reqs, pr_prdt);
>>> + spin_lock_irqsave(hba->host->host_lock, flags);
>>> + }
>>> +
>>> /*
>>> * if host reset is required then skip clearing the pending
>>> * transfers forcefully because they will get cleared during
>>> @@ -5900,22 +5915,6 @@ static irqreturn_t ufshcd_check_errors(struct
>>> ufs_hba *hba)
>>> /* block commands from scsi mid-layer */
>>> ufshcd_scsi_block_requests(hba);
>>> -
>>> - /* dump controller state before resetting */
>>> - if (hba->saved_err & (INT_FATAL_ERRORS | UIC_ERROR)) {
>>> - bool pr_prdt = !!(hba->saved_err &
>>> - SYSTEM_BUS_FATAL_ERROR);
>>> -
>>> - dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err
>>> 0x%x\n",
>>> - __func__, hba->saved_err,
>>> - hba->saved_uic_err);
>>> -
>>> - ufshcd_print_host_regs(hba);
>>> - ufshcd_print_pwr_info(hba);
>> How about keep the above prints and move the tmrs and trs to eh?
>> Sometimes in system instability, the eh may not get a chance to run
>> even. Still the above prints would provide some clues.
>
> Here is the IRQ handler, ufshcd_print_host_regs() is sometime heavy
> enough to cause stability issues during my fault injection test, since
> it prints host regs, reg's history, crypto debug infos plus prints
> from vops_dump.
>
> How about just printing host regs and reg history here? Most time, these
> infos are enough.
>
That'd work too.
> Thanks,
>
> Can Guo.
>
>>> - ufshcd_print_tmrs(hba, hba->outstanding_tasks);
>>> - ufshcd_print_trs(hba, hba->outstanding_reqs,
>>> - pr_prdt);
>>> - }
>>> ufshcd_schedule_eh_work(hba);
>>> retval |= IRQ_HANDLED;
>>> }
>>>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-07-29 22:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 5:00 [PATCH v7 0/8] Fix up and simplify error recovery mechanism Can Guo
2020-07-28 5:00 ` [PATCH v7 1/8] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-29 6:47 ` Stanley Chu
2020-07-28 5:00 ` [PATCH v7 2/8] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-07-28 5:00 ` [PATCH v7 3/8] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs Can Guo
2020-07-28 5:32 ` hongwus
2020-07-28 7:53 ` Avri Altman
2020-07-28 5:00 ` [PATCH v7 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-07-28 5:32 ` hongwus
2020-07-28 18:01 ` Asutosh Das (asd)
2020-07-29 7:00 ` Stanley Chu
2020-07-28 5:00 ` [PATCH v7 5/8] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-07-28 5:00 ` [PATCH v7 6/8] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-07-28 5:00 ` [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-07-28 18:06 ` Asutosh Das (asd)
2020-07-29 13:02 ` Can Guo
2020-07-29 22:45 ` Asutosh Das (asd) [this message]
2020-07-28 5:00 ` [PATCH v7 8/8] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
2020-07-28 21:44 ` [PATCH v7 0/8] Fix up and simplify error recovery mechanism Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66389fa-4ca2-bf7e-6b3d-d77eada4eb0e@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=sh425.lee@samsung.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).