From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Avri Altman <Avri.Altman@wdc.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"PedroM.Sousa@synopsys.com" <PedroM.Sousa@synopsys.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling
Date: Tue, 25 May 2021 09:44:29 -0700 [thread overview]
Message-ID: <daf42576-3b58-1645-c068-115355c0c494@codeaurora.org> (raw)
In-Reply-To: <CAF2Aj3gpMhPf8dF7cxcW0AhwGmGtf=LbO6HPB0u3FxudWTBcoQ@mail.gmail.com>
On 5/25/2021 12:57 AM, Lee Jones wrote:
> On Wed, 20 May 2020 at 22:59, Asutosh Das (asd) <asutoshd@codeaurora.org
> <mailto:asutoshd@codeaurora.org>> wrote:
>
> Hi Avri,
>
> On 5/20/2020 2:33 PM, Avri Altman wrote:
> > Hi,
> >
> >>
> >>
> >> Qualcomm controller needs to be in hibern8 before scaling clocks.
> >> This change puts the controller in hibern8 state before scaling
> >> and brings it out after scaling of clocks.
> >>
> >> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org
> <mailto:asutoshd@codeaurora.org>>
> >
> > I guess that your previous versions are pretty far back - ,
> > I noticed a comment by Pedro, so you might want to resend this
> series.
> >
> Ok.
>
> > What happens if the pre-change is successful,
> > but you are not getting to the post change because, e.g.
> ufshcd_set_clk_freq failed?
> >
> I agree. Let me check this.
>
> > Also, this piece of code is ~5 years old, so you might want to
> elaborate on how come hibernation is now needed.
> >
> > Thanks,
> > Avri
> >
>
> Thanks for the review. Hibernation was needed since long actually.
> I guess it was never pushed upstream.
>
>
> Good morning Asd,
>
> Any luck with getting this upstream?
>
> Looks like this was the last submission.
>
> Did something change? Is this no longer required?
>
Hi Lee
This slipped away. I may not get to this soon.
I'd prefer to drop it for now and come back to it when I've some time.
Thanks,
-asd
> --
> Lee Jones [李琼斯]
> Linaro Services Senior Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
prev parent reply other threads:[~2021-05-25 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:53 [PATCH v4 1/2] scsi: ufs: export hibern8 entry Asutosh Das
2020-05-20 17:53 ` [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling Asutosh Das
2020-05-20 21:33 ` Avri Altman
2020-05-20 21:59 ` Asutosh Das (asd)
[not found] ` <CAF2Aj3gpMhPf8dF7cxcW0AhwGmGtf=LbO6HPB0u3FxudWTBcoQ@mail.gmail.com>
2021-05-25 16:44 ` Asutosh Das (asd) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf42576-3b58-1645-c068-115355c0c494@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=PedroM.Sousa@synopsys.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).