From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
John Garry <john.garry@huawei.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/4] scsi: Introduct scsi_cmd_to_tag()
Date: Thu, 19 Aug 2021 09:59:29 -0700 [thread overview]
Message-ID: <dffab055-b9ad-cfc7-1d8e-bffdcb18d3c1@acm.org> (raw)
In-Reply-To: <20210819084007.79233-2-hare@suse.de>
On 8/19/21 1:40 AM, Hannes Reinecke wrote:
> +static inline u32 scsi_cmd_to_tag(struct scsi_cmnd *cmd)
> +{
> + struct request *rq = scsi_cmd_to_rq(cmd);
> +
> + return rq->tag;
> +}
Do we really need this function? If so, please change "Introduct" in the
subject into "Introduce". Additionally, how about renaming this function
into scsi_cmd_tag()? How about changing the function body into "return
scsi_cmd_to_rq(cmd)->tag"?
Thanks,
Bart.
next prev parent reply other threads:[~2021-08-19 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 8:40 [PATCH 0/4] scsi: remove last references to scsi_cmnd.tag Hannes Reinecke
2021-08-19 8:40 ` [PATCH 1/4] scsi: Introduct scsi_cmd_to_tag() Hannes Reinecke
2021-08-19 10:57 ` John Garry
2021-08-19 16:59 ` Bart Van Assche [this message]
2021-08-19 8:40 ` [PATCH 2/4] fas216: kill scmd->tag Hannes Reinecke
2021-08-19 8:40 ` [PATCH 3/4] acornscsi: remove tagged queuing vestiges Hannes Reinecke
2021-08-19 8:40 ` [PATCH 4/4] scsi: remove 'current_tag' Hannes Reinecke
2021-09-13 9:25 ` [PATCH 0/4] scsi: remove last references to scsi_cmnd.tag John Garry
2021-09-15 3:21 ` Martin K. Petersen
2021-09-15 7:34 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dffab055-b9ad-cfc7-1d8e-bffdcb18d3c1@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).