From: "zhengbin (A)" <zhengbin13@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <bvanassche@acm.org>, <jejb@linux.ibm.com>,
<linux-scsi@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH v4 2/2] scsi: core: fix uninit-value access of variable sshdr
Date: Fri, 18 Oct 2019 10:46:32 +0800 [thread overview]
Message-ID: <e14f87ac-5302-0a5e-0e77-bdc0933e332d@huawei.com> (raw)
In-Reply-To: <yq1y2xiixms.fsf@oracle.com>
On 2019/10/18 10:40, Martin K. Petersen wrote:
> zhengbin,
>
>> We can init sshdr in sr_get_events, but there have many callers of
>> scsi_execute, scsi_execute_req, we have to troubleshoot all callers,
>> the simpler way is init sshdr in __scsi_execute.
> There aren't that many callers. I'd prefer to make sure that everybody
> is handling DRIVER_SENSE and scsi_sense_valid() correctly. Looks like
> we're generally OK, but please verify.
OK, I have troubleshoot callers, there are similar bug(scsi_report_opcode, cache_type_store, scsi_test_unit_ready, scsi_report_lun_scan, sd_spinup_disk, read_capacity_16,
read_capacity_10, sr_get_events, alua_rtpg, alua_stpg, send_trespass_cmd, hp_sw_tur, hp_sw_start_stop, send_mode_select, sd_sync_cache, sd_start_stop_device, sr_do_ioctl).
I modify these in a patch? or every .c a patch, use a patchset?
>
> Thanks!
>
next prev parent reply other threads:[~2019-10-18 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 6:19 [PATCH v4 0/2] scsi: core: fix uninit-value access of variable sshdr zhengbin
2019-10-17 6:19 ` [PATCH v4 1/2] sr: need to check whether sshdr is valid in sr_do_ioctl zhengbin
2019-10-18 2:12 ` Martin K. Petersen
2019-10-18 2:38 ` Martin K. Petersen
2019-10-17 6:19 ` [PATCH v4 2/2] scsi: core: fix uninit-value access of variable sshdr zhengbin
2019-10-18 2:40 ` Martin K. Petersen
2019-10-18 2:46 ` zhengbin (A) [this message]
2019-10-18 2:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e14f87ac-5302-0a5e-0e77-bdc0933e332d@huawei.com \
--to=zhengbin13@huawei.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).