From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8870EC433E3 for ; Tue, 28 Jul 2020 02:21:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60C342075A for ; Tue, 28 Jul 2020 02:21:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AdRDJTwd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbgG1CVu (ORCPT ); Mon, 27 Jul 2020 22:21:50 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:27044 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgG1CVt (ORCPT ); Mon, 27 Jul 2020 22:21:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595902909; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Nd3Ki8cCx7FejuxD0mDfmmNE6PX98h/D7XuxA2n5jFE=; b=AdRDJTwd+J1ZJSuJm7GL7ctQcrtDkUbQ8W8Kr40JM0sBDR9lEwsMoGql+T8UBWhbwhbr7vVL pxl83Ye9J1rEpe/E5VbJIsJgzAP7UGULrf5pxscp+TwnN7AJif0Y4PZh8lHIggUNuJl41ylq XhV0yTyv8jVPehvY0fRImOdrg9Q= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJlNmU5NiIsICJsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f1f8bb536e6de324e42f612 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Jul 2020 02:21:41 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D132FC433CB; Tue, 28 Jul 2020 02:21:40 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id B9333C433C6; Tue, 28 Jul 2020 02:21:38 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jul 2020 10:21:38 +0800 From: Can Guo To: Avri Altman Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, sh425.lee@samsung.com, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Bjorn Andersson , Alim Akhtar , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v6 3/8] scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs In-Reply-To: References: <1595504787-19429-1-git-send-email-cang@codeaurora.org> <1595504787-19429-4-git-send-email-cang@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Avri, On 2020-07-27 21:05, Avri Altman wrote: >> Dumping testbus registers needs to sleep a bit intermittently as there >> are >> too many of them. Skip them for those contexts where sleep is not >> allowed. >> >> Signed-off-by: Can Guo >> --- >> drivers/scsi/ufs/ufs-qcom.c | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c >> index 7da27ee..7831b2b 100644 >> --- a/drivers/scsi/ufs/ufs-qcom.c >> +++ b/drivers/scsi/ufs/ufs-qcom.c >> @@ -1651,13 +1651,16 @@ static void ufs_qcom_dump_dbg_regs(struct >> ufs_hba *hba) >> ufshcd_dump_regs(hba, REG_UFS_SYS1CLK_1US, 16 * 4, >> "HCI Vendor Specific Registers "); >> >> - /* sleep a bit intermittently as we are dumping too much data >> */ >> ufs_qcom_print_hw_debug_reg_all(hba, NULL, >> ufs_qcom_dump_regs_wrapper); >> - udelay(1000); >> - ufs_qcom_testbus_read(hba); >> - udelay(1000); >> - ufs_qcom_print_unipro_testbus(hba); >> - udelay(1000); >> + >> + if (in_task()) { >> + /* sleep a bit intermittently as we are dumping too >> much data */ >> + usleep_range(1000, 1100); >> + ufs_qcom_testbus_read(hba); >> + usleep_range(1000, 1100); >> + ufs_qcom_print_unipro_testbus(hba); >> + usleep_range(1000, 1100); >> + } >> } > How about moving the intermittent sleep out of the check if preemption > is disabled? > And maybe then you need to switch back to uedlay? I will just remove all the testbus prints in next version to save us time here. Thanks, Can Guo.