From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1637C433E6 for ; Tue, 9 Mar 2021 15:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8026C6529E for ; Tue, 9 Mar 2021 15:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231916AbhCIP4x (ORCPT ); Tue, 9 Mar 2021 10:56:53 -0500 Received: from z11.mailgun.us ([104.130.96.11]:36456 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232037AbhCIP4m (ORCPT ); Tue, 9 Mar 2021 10:56:42 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615305402; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=/m2KFCZftUzumg8DPFWYqFDdMycSz9cl+cIGSvANNXM=; b=dbIGf1TcIw76uYoGYQqrAKHmUxd/VpQq+XHni252MORXn0n0njVvEiKGnwXD+tcCjGJ1pzpb m2hK4lI0lEeADPtHvG8vQ49+gQ7ppP5ct4CxvQG27Zd+UKnCHBOa5tmSEjA9nOql01ZYHuZS pr9+4dmDjk6PEDslmI2HeVnrkG8= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyJlNmU5NiIsICJsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60479ab3b2591bd568ff3b57 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Mar 2021 15:56:35 GMT Sender: asutoshd=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1E885C43478; Tue, 9 Mar 2021 15:56:34 +0000 (UTC) Received: from [192.168.8.168] (cpe-70-95-149-85.san.res.rr.com [70.95.149.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0D314C433CA; Tue, 9 Mar 2021 15:56:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0D314C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun To: "Rafael J. Wysocki" Cc: Alan Stern , "Rafael J. Wysocki" , Adrian Hunter , cang@codeaurora.org, "Martin K. Petersen" , "open list:TARGET SUBSYSTEM" , Bart Van Assche , linux-arm-msm , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Krzysztof Kozlowski , Stanley Chu , Andy Gross , Bjorn Andersson , Steven Rostedt , Ingo Molnar , Matthias Brugger , Kiwoong Kim , Bean Huo , Lee Jones , Wei Yongjun , Dinghao Liu , "Gustavo A. R. Silva" , Tomas Winkler , Jaegeuk Kim , Satya Tangirala , open list , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , Linux-PM mailing list References: <0576d6eae15486740c25767e2d8805f7e94eb79d.1614725302.git.asutoshd@codeaurora.org> <85086647-7292-b0a2-d842-290818bd2858@intel.com> <6e98724d-2e75-d1fe-188f-a7010f86c509@codeaurora.org> <20210306161616.GC74411@rowland.harvard.edu> From: "Asutosh Das (asd)" Message-ID: Date: Tue, 9 Mar 2021 07:56:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: > On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote: >> >> On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote: >>> >>> On Fri, Mar 05, 2021 at 06:54:24PM -0800, Asutosh Das (asd) wrote: >>> >>>> Now during my testing I see a weird issue sometimes (1 in 7). >>>> Scenario - bootups >>>> >>>> Issue: >>>> The supplier 'ufs_device_wlun 0:0:0:49488' goes into runtime suspend even >>>> when one/more of its consumers are in RPM_ACTIVE state. >>>> >>>> *Log: >>>> [ 10.056379][ T206] sd 0:0:0:1: [sdb] Synchronizing SCSI cache >>>> [ 10.062497][ T113] sd 0:0:0:5: [sdf] Synchronizing SCSI cache >>>> [ 10.356600][ T32] sd 0:0:0:7: [sdh] Synchronizing SCSI cache >>>> [ 10.362944][ T174] sd 0:0:0:3: [sdd] Synchronizing SCSI cache >>>> [ 10.696627][ T83] sd 0:0:0:2: [sdc] Synchronizing SCSI cache >>>> [ 10.704562][ T170] sd 0:0:0:6: [sdg] Synchronizing SCSI cache >>>> [ 10.980602][ T5] sd 0:0:0:0: [sda] Synchronizing SCSI cache >>>> >>>> /** Printing all the consumer nodes of supplier **/ >>>> [ 10.987327][ T5] ufs_device_wlun 0:0:0:49488: usage-count @ suspend: 0 >>>> <-- this is the usage_count >>>> [ 10.994440][ T5] ufs_rpmb_wlun 0:0:0:49476: PM state - 2 >>>> [ 11.000402][ T5] scsi 0:0:0:49456: PM state - 2 >>>> [ 11.005453][ T5] sd 0:0:0:0: PM state - 2 >>>> [ 11.009958][ T5] sd 0:0:0:1: PM state - 2 >>>> [ 11.014469][ T5] sd 0:0:0:2: PM state - 2 >>>> [ 11.019072][ T5] sd 0:0:0:3: PM state - 2 >>>> [ 11.023595][ T5] sd 0:0:0:4: PM state - 0 << RPM_ACTIVE >>>> [ 11.353298][ T5] sd 0:0:0:5: PM state - 2 >>>> [ 11.357726][ T5] sd 0:0:0:6: PM state - 2 >>>> [ 11.362155][ T5] sd 0:0:0:7: PM state - 2 >>>> [ 11.366584][ T5] ufshcd-qcom 1d84000.ufshc: __ufshcd_wl_suspend - 8709 >>>> [ 11.374366][ T5] ufs_device_wlun 0:0:0:49488: __ufshcd_wl_suspend - >>>> (0) has rpm_active flags >> >> Do you mean that rpm_active of the link between the consumer and the >> supplier is greater than 0 at this point and the consumer is > > I mean is rpm_active of the link greater than 1 (because 1 means "no > active references to the supplier")? Hi Rafael: No - it is not greater than 1. I'm trying to understand what's going on in it; will update when I've something. > >> RPM_ACTIVE, but the supplier suspends successfully nevertheless? >> >>>> [ 11.383376][ T5] ufs_device_wlun 0:0:0:49488: >>>> ufshcd_wl_runtime_suspend <-- Supplier suspends fine. >>>> [ 12.977318][ T174] sd 0:0:0:4: [sde] Synchronizing SCSI cache >>>> >>>> And the the suspend of sde is stuck now: >>>> schedule+0x9c/0xe0 >>>> schedule_timeout+0x40/0x128 >>>> io_schedule_timeout+0x44/0x68 >>>> wait_for_common_io+0x7c/0x100 >>>> wait_for_completion_io+0x14/0x20 >>>> blk_execute_rq+0x90/0xcc >>>> __scsi_execute+0x104/0x1c4 >>>> sd_sync_cache+0xf8/0x2a0 >>>> sd_suspend_common+0x74/0x11c >>>> sd_suspend_runtime+0x14/0x20 >>>> scsi_runtime_suspend+0x64/0x94 >>>> __rpm_callback+0x80/0x2a4 >>>> rpm_suspend+0x308/0x614 >>>> pm_runtime_work+0x98/0xa8 >>>> >>>> I added 'DL_FLAG_RPM_ACTIVE' while creating links. >>>> if (hba->sdev_ufs_device) { >>>> link = device_link_add(&sdev->sdev_gendev, >>>> &hba->sdev_ufs_device->sdev_gendev, >>>> DL_FLAG_PM_RUNTIME|DL_FLAG_RPM_ACTIVE); >>>> I didn't expect this to resolve the issue anyway and it didn't. >>>> >>>> Another interesting point here is when I resume any of the above suspended >>>> consumers, it all goes back to normal, which is kind of expected. I tried >>>> resuming the consumer and the supplier is resumed and the supplier is >>>> suspended when all the consumers are suspended. >>>> >>>> Any pointers on this issue please? >>>> >>>> @Bart/@Alan - Do you've any pointers please? >>> >>> It's very noticeable that although you seem to have isolated a bug in >>> the power management subsystem (supplier goes into runtime suspend >>> even when one of its consumers is still active), you did not CC the >>> power management maintainer or mailing list. >>> >>> I have added the appropriate CC's. >> >> Thanks Alan! -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project