From: hongwus@codeaurora.org
To: Can Guo <cang@codeaurora.org>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, sh425.lee@samsung.com,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config
Date: Thu, 23 Jul 2020 11:38:08 +0800 [thread overview]
Message-ID: <f8a94108c8d063336f844a812e59020e@codeaurora.org> (raw)
In-Reply-To: <1595471649-25675-4-git-send-email-cang@codeaurora.org>
On 2020-07-23 10:34, Can Guo wrote:
> If ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from
> ufshcd_suspend/resume and/or clk gate/ungate context,
> pm_runtime_get_sync()
> and ufshcd_hold() will cause racing problems. Fix this by removing the
> unnecessary calls of pm_runtime_get_sync() and ufshcd_hold().
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 2e6ddb5..7da27ee 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1604,9 +1604,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host
> *host)
> */
> }
> mask <<= offset;
> -
> - pm_runtime_get_sync(host->hba->dev);
> - ufshcd_hold(host->hba, false);
> ufshcd_rmwl(host->hba, TEST_BUS_SEL,
> (u32)host->testbus.select_major << 19,
> REG_UFS_CFG1);
> @@ -1619,8 +1616,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host
> *host)
> * committed before returning.
> */
> mb();
> - ufshcd_release(host->hba);
> - pm_runtime_put_sync(host->hba->dev);
>
> return 0;
> }
Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
next prev parent reply other threads:[~2020-07-23 3:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 2:33 [PATCH v5 0/9] Fix up and simplify error recovery mechanism Can Guo
2020-07-23 2:34 ` [PATCH v5 1/9] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-23 2:45 ` hongwus
2020-07-23 2:34 ` [PATCH v5 2/9] scsi: ufs: Fix imbalanced scsi_block_reqs_cnt caused by ufshcd_hold() Can Guo
2020-07-23 3:20 ` hongwus
2020-07-23 2:34 ` [PATCH v5 3/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-07-23 3:38 ` hongwus [this message]
2020-07-23 2:34 ` [PATCH v5 4/9] scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs Can Guo
2020-07-23 2:34 ` [PATCH v5 5/9] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-07-23 2:34 ` [PATCH v5 6/9] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-07-23 2:34 ` [PATCH v5 7/9] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-07-23 2:34 ` [PATCH v5 8/9] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-07-23 2:34 ` [PATCH v5 9/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a94108c8d063336f844a812e59020e@codeaurora.org \
--to=hongwus@codeaurora.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).