From: Bean Huo <huobean@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off
Date: Tue, 19 Jan 2021 10:33:45 +0100 [thread overview]
Message-ID: <fabf0e83387f6155efea521a15b00bb1225d35a4.camel@gmail.com> (raw)
In-Reply-To: <0a9971aa-e508-2aaa-1379-fb898471a252@intel.com>
On Tue, 2021-01-19 at 09:01 +0200, Adrian Hunter wrote:
> On 18/01/21 10:10 pm, Bean Huo wrote:
> > From: Bean Huo <beanhuo@micron.com>
> >
> > Currently UFS WriteBooster driver uses clock scaling up/down to set
> > WB on/off, for the platform which doesn't support
> > UFSHCD_CAP_CLK_SCALING,
> > WB will be always on. Provide a sysfs attribute to enable/disable
> > WB
> > during runtime. Write 1/0 to "wb_on" sysfs node to enable/disable
> > UFS WB.
>
> Is it so, that after a full reset, WB is always enabled again? Is
> that
> intended?
Hello Adrian
Good questions. yes, after a full reset, the UFS device side by default
is wb disabled, then WB will be always enabled agaion in
ufshcd_wb_config(hba). but, for the platform which
supports UFSHCD_CAP_CLK_SCALING, wb will be disabled again while clk
scaling down and enabled while clk scaling up.
Regarding the last question, I think OEM wants to do that. maybe they
suppose there will be a lot of writing after reset?? From the UFS
device's point of view, the control of WB is up to the user.
Thanks,
Bean
next prev parent reply other threads:[~2021-01-19 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:10 [PATCH v6 0/6] Several changes for UFS WriteBooster Bean Huo
2021-01-18 20:10 ` [PATCH v6 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off Bean Huo
2021-01-19 7:01 ` Adrian Hunter
2021-01-19 9:33 ` Bean Huo [this message]
2021-01-19 10:00 ` Adrian Hunter
2021-01-19 16:31 ` Bean Huo
2021-01-18 20:10 ` [PATCH v6 2/6] docs: ABI: Add wb_on documentation for UFS sysfs Bean Huo
2021-01-18 20:10 ` [PATCH v6 3/6] scsi: ufs: Changes comment in the function ufshcd_wb_probe() Bean Huo
2021-01-18 20:10 ` [PATCH v6 4/6] scsi: ufs: Remove two WB related fields from struct ufs_dev_info Bean Huo
2021-01-18 20:10 ` [PATCH v6 5/6] scsi: ufs: Group UFS WB related flags to " Bean Huo
2021-01-18 20:10 ` [PATCH v6 6/6] scsi: ufs: Cleanup WB buffer flush toggle implementation Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabf0e83387f6155efea521a15b00bb1225d35a4.camel@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).