From: Yanling song <yanling.song@linux.dev>
To: Bart Van Assche <bvanassche@acm.org>,
Yanling Song <songyl@ramaxel.com>,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, yujiang@ramaxel.com,
xuyun@ramaxel.com, yanggan@ramaxel.com
Subject: Re: [PATCH V2] scsi:spraid: initial commit of Ramaxel spraid driver
Date: Sun, 12 Dec 2021 03:02:25 +0000 [thread overview]
Message-ID: <fcb61728-00c3-08e5-9c5a-a545dabd3c58@linux.dev> (raw)
In-Reply-To: <b5002b52-3654-825c-f94f-f9ade708042e@acm.org>
On 12/10/21 5:42 PM, Bart Van Assche wrote:
> On 11/25/21 11:33 PM, Yanling Song wrote:
>> +config RAMAXEL_SPRAID
>> + tristate "Ramaxel spraid Adapter"
>> + depends on PCI && SCSI && BLK_DEV_BSGLIB
>> + depends on ARM64 || X86_64
>
> Why is this driver restricted to ARM64 and X86_64 systems? What prevents
> compilation of this driver on other CPU architectures?
>
The target market of spraid controller is ARM and X86.
In theory, spraid driver can also work on other CPU architectures but not tested yet.
>> + help
>> + This driver supports Ramaxel spraid driver.
>
> The help text is too short. Please add one or two sentences about the interface
> type of this RAID controller (PCIe?) and also about the storage media supported
> by this RAID controller (SAS? SATA? any other?).
>
More help text will be included in the next version:
This driver supports Ramaxel SPRxxx serial raid controller, which has PCIE Gen4 interface with host
and supports SAS/SATA Hdd/ssd.
>> +struct spraid_bsg_request {
>> + u32 msgcode;
>> + u32 control;
>> + union {
>> + struct spraid_passthru_common_cmd admcmd;
>> + struct spraid_ioq_passthru_cmd ioqcmd;
>> + };
>> +};
>
> Definitions like the above are required by user space software that uses the
> BSG interface and hence should be moved into a header file under include/uapi/.
> See e.g. include/uapi/scsi/scsi_bsg_ufs.h.
>
The definitions are for our own private tool and cannot be used by others.
Does it make sense to put it in include/uapi/scsi?
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2021-12-12 3:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 7:33 [PATCH V2] scsi:spraid: initial commit of Ramaxel spraid driver Yanling Song
2021-11-26 16:21 ` James Bottomley
2021-11-26 19:24 ` Randy Dunlap
[not found] ` <20211130113449.45751209@songyl>
2021-12-01 0:26 ` Yanling song
2021-11-29 13:04 ` Hannes Reinecke
[not found] ` <20211130113836.1bb8e91c@songyl>
2021-11-30 11:55 ` Hannes Reinecke
2021-12-02 13:56 ` Yanling song
2021-12-06 17:00 ` Bart Van Assche
2021-12-09 23:15 ` Bart Van Assche
2021-12-10 17:42 ` Bart Van Assche
2021-12-12 3:02 ` Yanling song [this message]
2021-12-10 21:40 ` Bart Van Assche
2021-12-12 3:04 ` Yanling song
2021-12-12 2:56 ` yanling.song
2021-12-27 7:55 ` Yanling Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb61728-00c3-08e5-9c5a-a545dabd3c58@linux.dev \
--to=yanling.song@linux.dev \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=songyl@ramaxel.com \
--cc=xuyun@ramaxel.com \
--cc=yanggan@ramaxel.com \
--cc=yujiang@ramaxel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).